Issue 186110: Shindig javascript cleanups for closure compiler

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 186110: Shindig javascript cleanups for closure compiler (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 8 months ago by Paul Lindner

Modified:
15 years, 5 months ago

Reviewers:
johnfargo

Visibility:
Public.

Patch Set 1 #

Total comments: 3

Patch Set 2 : Updates for line length and more warning fixes #

Created: 15 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+523 lines, -467 lines)			Patch
M	features/src/main/javascript/features/core.auth/auth.js	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	features/src/main/javascript/features/core.config/config.js	View		4 chunks	+6 lines, -6 lines	0 comments	Download
M	features/src/main/javascript/features/core.io/io.js	View	1	11 chunks	+34 lines, -25 lines	0 comments	Download
M	features/src/main/javascript/features/core.json/json.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	features/src/main/javascript/features/core.legacy/legacy.js	View		12 chunks	+36 lines, -24 lines	0 comments	Download
M	features/src/main/javascript/features/core.log/log.js	View		6 chunks	+9 lines, -9 lines	0 comments	Download
M	features/src/main/javascript/features/core.prefs/prefs.js	View		12 chunks	+18 lines, -18 lines	0 comments	Download
M	features/src/main/javascript/features/core.util/util.js	View		13 chunks	+34 lines, -18 lines	0 comments	Download
M	features/src/main/javascript/features/dynamic-height/dynamic-height.js	View		3 chunks	+5 lines, -5 lines	0 comments	Download
M	features/src/main/javascript/features/flash/flash.js	View		3 chunks	+8 lines, -9 lines	0 comments	Download
M	features/src/main/javascript/features/i18n/formatting.js	View		4 chunks	+7 lines, -7 lines	0 comments	Download
M	features/src/main/javascript/features/i18n/numberformat.js	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	features/src/main/javascript/features/minimessage/minimessage.js	View		7 chunks	+12 lines, -12 lines	0 comments	Download
M	features/src/main/javascript/features/oauthpopup/oauthpopup.js	View		3 chunks	+6 lines, -8 lines	0 comments	Download
	features/src/main/javascript/features/opensocial-0.6/feature.xml	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	features/src/main/javascript/features/opensocial-data-context/datacontext.js	View	1	8 chunks	+8 lines, -8 lines	0 comments	Download
M	features/src/main/javascript/features/opensocial-data/data.js	View	1	7 chunks	+11 lines, -11 lines	0 comments	Download
	features/src/main/javascript/features/opensocial-data/feature.xml	View		1 chunk	+1 line, -1 line	0 comments	Download
M	features/src/main/javascript/features/opensocial-jsonrpc/jsonrpccontainer.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	features/src/main/javascript/features/opensocial-reference/activity.js	View		5 chunks	+8 lines, -8 lines	0 comments	Download
M	features/src/main/javascript/features/opensocial-reference/address.js	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	features/src/main/javascript/features/opensocial-reference/bodytype.js	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	features/src/main/javascript/features/opensocial-reference/collection.js	View		6 chunks	+6 lines, -6 lines	0 comments	Download
M	features/src/main/javascript/features/opensocial-reference/container.js	View	1	21 chunks	+34 lines, -35 lines	0 comments	Download
M	features/src/main/javascript/features/opensocial-reference/datarequest.js	View		16 chunks	+23 lines, -24 lines	0 comments	Download
M	features/src/main/javascript/features/opensocial-reference/dataresponse.js	View	1	3 chunks	+5 lines, -4 lines	0 comments	Download
M	features/src/main/javascript/features/opensocial-reference/email.js	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	features/src/main/javascript/features/opensocial-reference/enum.js	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	features/src/main/javascript/features/opensocial-reference/environment.js	View		3 chunks	+5 lines, -5 lines	0 comments	Download
M	features/src/main/javascript/features/opensocial-reference/idspec.js	View		2 chunks	+5 lines, -5 lines	0 comments	Download
M	features/src/main/javascript/features/opensocial-reference/mediaitem.js	View		3 chunks	+7 lines, -7 lines	0 comments	Download
M	features/src/main/javascript/features/opensocial-reference/message.js	View	1	3 chunks	+7 lines, -7 lines	0 comments	Download
M	features/src/main/javascript/features/opensocial-reference/messagecollection.js	View	1	3 chunks	+6 lines, -7 lines	0 comments	Download
M	features/src/main/javascript/features/opensocial-reference/name.js	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	features/src/main/javascript/features/opensocial-reference/navigationparameters.js	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	features/src/main/javascript/features/opensocial-reference/opensocial.js	View	1	10 chunks	+19 lines, -19 lines	0 comments	Download
M	features/src/main/javascript/features/opensocial-reference/organization.js	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	features/src/main/javascript/features/opensocial-reference/person.js	View	1	6 chunks	+9 lines, -9 lines	0 comments	Download
M	features/src/main/javascript/features/opensocial-reference/phone.js	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	features/src/main/javascript/features/opensocial-reference/responseitem.js	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	features/src/main/javascript/features/opensocial-reference/url.js	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	features/src/main/javascript/features/opensocial-templates/base.js	View		4 chunks	+5 lines, -5 lines	0 comments	Download
M	features/src/main/javascript/features/opensocial-templates/compiler.js	View	1	9 chunks	+12 lines, -12 lines	0 comments	Download
M	features/src/main/javascript/features/opensocial-templates/container.js	View		8 chunks	+11 lines, -11 lines	0 comments	Download
M	features/src/main/javascript/features/opensocial-templates/jsTemplate/jsevalcontext.js	View		4 chunks	+7 lines, -7 lines	0 comments	Download
M	features/src/main/javascript/features/opensocial-templates/jsTemplate/jstemplate.js	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	features/src/main/javascript/features/opensocial-templates/jsTemplate/util.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	features/src/main/javascript/features/opensocial-templates/os.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	features/src/main/javascript/features/opensocial-templates/template.js	View	1	3 chunks	+4 lines, -2 lines	0 comments	Download
M	features/src/main/javascript/features/osapi/batch.js	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	features/src/main/javascript/features/osapi/gadgetsrpctransport.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	features/src/main/javascript/features/osapi/jsonrpctransport.js	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	features/src/main/javascript/features/osapi/osapi.js	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	features/src/main/javascript/features/pubsub/pubsub.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	features/src/main/javascript/features/pubsub/pubsub-router.js	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	features/src/main/javascript/features/rpc/ifpc.transport.js	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	features/src/main/javascript/features/rpc/rmr.transport.js	View		2 chunks	+6 lines, -6 lines	0 comments	Download
M	features/src/main/javascript/features/rpc/rpc.js	View	1	12 chunks	+29 lines, -21 lines	0 comments	Download
M	features/src/main/javascript/features/setprefs/setprefs.js	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download
M	features/src/main/javascript/features/settitle/settitle.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	features/src/main/javascript/features/skins/skins.js	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	features/src/main/javascript/features/tabs/tabs.js	View	1	18 chunks	+24 lines, -24 lines	0 comments	Download
M	features/src/main/javascript/features/views/views.js	View	1	11 chunks	+29 lines, -11 lines	0 comments	Download
M	features/src/main/javascript/features/xmlutil/xmlutil.js	View		4 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

johnfargo

15 years, 8 months ago (2010-01-12 21:24:11 UTC) #1

Looks great, albeit with some line-length-exceeded issues.

http://codereview.appspot.com/186110/diff/1/4
File features/src/main/javascript/features/core.io/io.js (right):

http://codereview.appspot.com/186110/diff/1/4#newcode229
features/src/main/javascript/features/core.io/io.js:229: * @param {string=}
opt_contentType - Optional content type defaults to
'application/x-www-form-urlencoded'
long line

http://codereview.appspot.com/186110/diff/1/4#newcode262
features/src/main/javascript/features/core.io/io.js:262: * @return {boolean}
true if the request can be satisfied by the preloaded content
long line, if we're doing 80char for JS

http://codereview.appspot.com/186110/diff/1/4#newcode323
features/src/main/javascript/features/core.io/io.js:323: * @param
{function(Object)} callback The function to call with the data from the
same (here and elsewhere)

Expand All Messages | Collapse All Messages