Improve search_rec_name to take care of ' / ' for issue1369

[h.goebel, 2010-01-12 12:11:28]

http://codereview.appspot.com/186096/diff/1/2
File category.py (right):

http://codereview.appspot.com/186096/diff/1/2#newcode67
category.py:67: j = 0
Replace by this. It's shorter and more efficient:
field = 'name'
has_parent = False
for name in values:
    if has_parent:
        field = 'parent.' + field
    domain.append((field, name))
    has_parent = True

[ced, 2010-01-12 12:18:53]

http://codereview.appspot.com/186096/diff/1/2
File category.py (right):

http://codereview.appspot.com/186096/diff/1/2#newcode67
category.py:67: j = 0
On 2010/01/12 12:11:28, h.goebel wrote:
> Replace by this. It's shorter and more efficient:
> field = 'name'
> has_parent = False
> for name in values:
>     if has_parent:
>         field = 'parent.' + field
>     domain.append((field, name))
>     has_parent = True
> 

I don't understand. It doesn't do the same.
It construct a string like this: 'parent.parent.parent.name' depending of the
number of ' / ' in the string.

[h.goebel, 2010-01-12 13:11:25]

On 2010/01/12 12:18:53, ced wrote:

> I don't understand. It doesn't do the same.

Of course the result is the same -- as it should be.
Your code builds the 'parent.parent.parent.' part from scratch in each
iteration. But one iteration before 'parent.parent.name' has already been build.
So there is no need to start from scratch, instead just prpend another 'parent.'

[h.goebel, 2010-01-12 14:02:08]

http://codereview.appspot.com/186096/diff/9/1003
File category.py (right):

http://codereview.appspot.com/186096/diff/9/1003#newcode69
category.py:69: if not field:
For the first iteration this condition will always be true, since two lines
above field has just been set to ''.

By alway setting 'field' for the *next* iteration, this could be written even
shorter.

field = 'name'
for name in values:
    domain.append((field, args[i][1], name))
    field = 'parent.' + field

[ced, 2010-01-12 14:07:28]

http://codereview.appspot.com/186096/diff/9/1003
File category.py (right):

http://codereview.appspot.com/186096/diff/9/1003#newcode69
category.py:69: if not field:
On 2010/01/12 14:02:08, h.goebel wrote:
> For the first iteration this condition will always be true, since two lines
> above field has just been set to ''.

'' is evaluated to False in Python.

> 
> By alway setting 'field' for the *next* iteration, this could be written even
> shorter.
> 
> field = 'name'
> for name in values:
>     domain.append((field, args[i][1], name))
>     field = 'parent.' + field
> 

Yes better.

[bch, 2010-01-12 18:32:06]

On 2010/01/12 14:07:48, ced wrote:
> 

OK

[h.goebel, 2010-01-12 22:18:48]

Okay. Tested with several files.

Please backport to 1.4, too. Thanks!

[ced, 2010-01-12 22:37:15]

On 2010/01/12 22:18:48, h.goebel wrote:
> Okay. Tested with several files.
> 
> Please backport to 1.4, too. Thanks!

For me, it is not a bug fix as it change the previous behavior of
search_rec_name and adds a constraint. So it doesn't enter in the release
policy.