Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1841)

Issue 186054: Add -dmusic-strings-to-paths and enable for SVG backend. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 4 months ago by Patrick McCarty
Modified:
14 years, 4 months ago
Reviewers:
joeneeman
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Add -dmusic-strings-to-paths and enable for SVG backend. * Using a -dmusic-strings-to-paths option generalizes the check (lily/pango-font.cc) to see if the "utf-8-string" stencil expression should be used for a backend. * Enable the new option only if it's found in a list of supported backends (scm/lily.scm). Currently, only the SVG backend supports this. In the future, more backends might support this option. * Update comments.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use global variable music_strings_as_paths #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -16 lines) Patch
M lily/pango-font.cc View 1 2 chunks +16 lines, -12 lines 0 comments Download
M lily/program-option-scheme.cc View 1 2 chunks +6 lines, -0 lines 0 comments Download
M lily/text-interface.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M scm/lily.scm View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 3
joeneeman
http://codereview.appspot.com/186054/diff/1/2 File lily/pango-font.cc (right): http://codereview.appspot.com/186054/diff/1/2#newcode384 lily/pango-font.cc:384: bool to_paths = get_program_option ("music-strings-to-paths"); It would be more ...
14 years, 4 months ago (2010-01-10 05:03:30 UTC) #1
Patrick McCarty
On 2010/01/10 05:03:30, joeneeman wrote: > http://codereview.appspot.com/186054/diff/1/2 > File lily/pango-font.cc (right): > > http://codereview.appspot.com/186054/diff/1/2#newcode384 > ...
14 years, 4 months ago (2010-01-10 06:40:56 UTC) #2
joeneeman
14 years, 4 months ago (2010-01-10 08:09:32 UTC) #3
On 2010/01/10 06:40:56, Patrick McCarty wrote:
> On 2010/01/10 05:03:30, joeneeman wrote:
> > http://codereview.appspot.com/186054/diff/1/2
> > File lily/pango-font.cc (right):
> > 
> > http://codereview.appspot.com/186054/diff/1/2#newcode384
> > lily/pango-font.cc:384: bool to_paths = get_program_option
> > ("music-strings-to-paths");
> > It would be more consistent, I think, to use a global variable here.
> 
> Done.
> 
> > http://codereview.appspot.com/186054/diff/1/2#newcode386
> > lily/pango-font.cc:386: if (has_utf8_string && ((to_paths && !music_string)
||
> > !to_paths))
> > If I understand this correctly, the SVG backend will now output feta
> characters
> > using utf-8-string by default (ie. unless the user manually specifies
> > -dmusic-strings-to-paths)?
> 
> It's actually the opposite.  -dmusic-strings-to-paths is true by default for
the
> SVG backend, which is now set in scm/lily.scm.  The backend will only use
> utf-8-string when a "non-music string" is encountered.

Oops, I missed the second chunk of lily.scm. LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b