Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(359)

Issue 1855057: Reject shaders that invoke functions hidden by variable or struct name.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 7 months ago by Alok Priyadarshi
Modified:
13 years, 7 months ago
Reviewers:
kbr1, dgkoch
CC:
angleproject-review_googlegroups.com
Base URL:
http://angleproject.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Reject shaders that invoke functions hidden by variable or struct name. BUG=22

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M src/compiler/ParseHelper.cpp View 1 chunk +10 lines, -7 lines 1 comment Download

Messages

Total messages: 5
Alok Priyadarshi
13 years, 7 months ago (2010-08-05 20:38:46 UTC) #1
kbr1
http://codereview.appspot.com/1855057/diff/1/2 File src/compiler/ParseHelper.cpp (right): http://codereview.appspot.com/1855057/diff/1/2#newcode920 src/compiler/ParseHelper.cpp:920: symbol = symbolTable.find(call->getMangledName(), builtIn); What does mangling handle? Overloading? ...
13 years, 7 months ago (2010-08-05 23:34:11 UTC) #2
Alok Priyadarshi
Functions are always registered with a mangled name. My CL ensures that there is no ...
13 years, 7 months ago (2010-08-06 00:02:50 UTC) #3
kbr1
On 2010/08/06 00:02:50, alokp wrote: > Functions are always registered with a mangled name. My ...
13 years, 7 months ago (2010-08-06 00:24:45 UTC) #4
dgkoch
13 years, 7 months ago (2010-08-06 02:25:10 UTC) #5
look alright. 

Daniel
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b