http://codereview.appspot.com/1855057/diff/1/2 File src/compiler/ParseHelper.cpp (right): http://codereview.appspot.com/1855057/diff/1/2#newcode920 src/compiler/ParseHelper.cpp:920: symbol = symbolTable.find(call->getMangledName(), builtIn); What does mangling handle? Overloading? ...
13 years, 7 months ago
(2010-08-05 23:34:11 UTC)
#2
http://codereview.appspot.com/1855057/diff/1/2
File src/compiler/ParseHelper.cpp (right):
http://codereview.appspot.com/1855057/diff/1/2#newcode920
src/compiler/ParseHelper.cpp:920: symbol =
symbolTable.find(call->getMangledName(), builtIn);
What does mangling handle? Overloading? If so, is any variant of the function
registered under the unmangled name? If so, this logic is wrong. It should look
up by mangled name and only fail if a temporary lookup by unmangled name returns
a symbol that is not a function.
Functions are always registered with a mangled name. My CL ensures that there is no ...
13 years, 7 months ago
(2010-08-06 00:02:50 UTC)
#3
Functions are always registered with a mangled name. My CL ensures that there is
no variable /struct in the current or parent scope namespace that hides this
function. Since functions can only be defined in the global scope, the opposite
is not true i.e. a function cannot hide a variable in the parent scope.
On 2010/08/06 00:02:50, alokp wrote: > Functions are always registered with a mangled name. My ...
13 years, 7 months ago
(2010-08-06 00:24:45 UTC)
#4
On 2010/08/06 00:02:50, alokp wrote:
> Functions are always registered with a mangled name. My CL ensures that there
is
> no variable /struct in the current or parent scope namespace that hides this
> function. Since functions can only be defined in the global scope, the
opposite
> is not true i.e. a function cannot hide a variable in the parent scope.
OK. LGTM.
Issue 1855057: Reject shaders that invoke functions hidden by variable or struct name....
(Closed)
Created 13 years, 7 months ago by Alok Priyadarshi
Modified 13 years, 7 months ago
Reviewers: kbr1, dgkoch
Base URL: http://angleproject.googlecode.com/svn/trunk/
Comments: 1