Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1135)

Issue 1854047: Remove sidedness flag from closures (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 9 months ago by aconty
Modified:
14 years, 3 months ago
Reviewers:
dev-osl <dev-osl, osl-dev, ckulla
Base URL:
http://openshadinglanguage.googlecode.com/svn/trunk/
Visibility:
Public.

Description

And also adding the backfacing() function for the shaders to be able to handle that directly.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+423 lines, -655 lines) Patch
src/include/oslclosure.h View 6 chunks +7 lines, -113 lines 0 comments Download
src/include/oslexec.h View 3 chunks +3 lines, -2 lines 0 comments Download
src/liboslcomp/typecheck.cpp View 1 chunk +1 line, -0 lines 0 comments Download
src/liboslexec/bsdf_ashikhmin_velvet.cpp View 3 chunks +43 lines, -47 lines 0 comments Download
src/liboslexec/bsdf_cloth.cpp View 3 chunks +4 lines, -8 lines 0 comments Download
src/liboslexec/bsdf_cloth_specular.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
src/liboslexec/bsdf_diffuse.cpp View 4 chunks +32 lines, -38 lines 0 comments Download
src/liboslexec/bsdf_fakefur.cpp View 11 chunks +72 lines, -78 lines 0 comments Download
src/liboslexec/bsdf_hair.cpp View 4 chunks +8 lines, -8 lines 0 comments Download
src/liboslexec/bsdf_microfacet.cpp View 24 chunks +51 lines, -79 lines 0 comments Download
src/liboslexec/bsdf_phong.cpp View 8 chunks +24 lines, -30 lines 0 comments Download
src/liboslexec/bsdf_reflection.cpp View 4 chunks +17 lines, -24 lines 0 comments Download
src/liboslexec/bsdf_refraction.cpp View 6 chunks +30 lines, -31 lines 0 comments Download
src/liboslexec/bsdf_transparent.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
src/liboslexec/bsdf_ward.cpp View 5 chunks +14 lines, -17 lines 0 comments Download
src/liboslexec/bsdf_westin.cpp View 7 chunks +29 lines, -35 lines 0 comments Download
src/liboslexec/builtin_closures.cpp View 2 chunks +28 lines, -33 lines 0 comments Download
src/liboslexec/closure_test.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
src/liboslexec/context.cpp View 1 chunk +1 line, -0 lines 0 comments Download
src/liboslexec/emissive.cpp View 1 chunk +0 lines, -1 line 0 comments Download
src/liboslexec/llvm_instance.cpp View 7 chunks +7 lines, -48 lines 0 comments Download
src/liboslexec/llvm_ops.cpp View 2 chunks +9 lines, -24 lines 0 comments Download
src/liboslexec/master.cpp View 1 chunk +1 line, -0 lines 0 comments Download
src/liboslexec/opattribute.cpp View 1 chunk +20 lines, -0 lines 0 comments Download
src/liboslexec/opclosure.cpp View 3 chunks +2 lines, -18 lines 0 comments Download
src/liboslexec/oslexec_pvt.h View 3 chunks +3 lines, -4 lines 0 comments Download
src/liboslexec/oslops.h View 1 chunk +1 line, -0 lines 0 comments Download
src/liboslexec/shadingsys.cpp View 3 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 2
aconty
14 years, 9 months ago (2010-08-03 18:54:24 UTC) #1
ckulla
14 years, 9 months ago (2010-08-05 23:21:30 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b