Issue 1847046: Add support for TTC font files in SkFontHost_Freetype....

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1847046: Add support for TTC font files in SkFontHost_Freetype....

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 3 months ago by jshin

Modified:
14 years, 3 months ago

Reviewers:
agl

CC:
skia-review_googlegroups.com, evan

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Add support for TTC font files in SkFontHost_Freetype. This is a companion change to a Chrome CL ( http://codereview.chromium.org/2870073/show ) BUG=http://crbug.com/50389 TEST=See the Chromium CL mentioned above.

Patch Set 1 #

Created: 14 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	src/ports/SkFontHost_FreeType.cpp	View		1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

jshin

Thank you for the review. Can you check this in? The chrome-side change was just ...

14 years, 3 months ago (2010-08-06 18:05:57 UTC) #4

agl

14 years, 3 months ago (2010-08-06 18:10:31 UTC) #5

On Fri, Aug 6, 2010 at 2:05 PM,  <jshin@chromium.org> wrote:
> Thank you for the review. Can you check this in? The chrome-side change
> was just checked in (implementing GetFileName only to retrieve the face
> index). Then, I'll update skia revision on Chrome-side (after running
> webkit tests).

Landed as r593.


AGL

Expand All Messages | Collapse All Messages