src/pkg/os/signal/Makefile - Issue 183142: code review 183142: Replicate signal names from syscall in os/signal.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: src/pkg/os/signal/Makefile

Issue 183142: code review 183142: Replicate signal names from syscall in os/signal. (Closed)

Patch Set: code review 183142: Replicate signal names from syscall in os/signal. Created 15 years, 2 months ago

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright 2009 The Go Authors. All rights reserved.	1 # Copyright 2009 The Go Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style	2 # Use of this source code is governed by a BSD-style

3 # license that can be found in the LICENSE file.	3 # license that can be found in the LICENSE file.

4	4

5 include ../../../Make.$(GOARCH)	5 include ../../../Make.$(GOARCH)

6	6

7 TARG=os/signal	7 TARG=os/signal

8 GOFILES=\	8 GOFILES=\

9 signal.go\	9 signal.go\

	10 unix_signals.go\
	rsc 2010/01/07 16:30:06 Might as well call it unix.go. You're already in Might as well call it unix.go. You're already in package signal. dsymonds 2010/01/07 22:58:17 Done. Show quoted text On 2010/01/07 16:30:06, rsc wrote: > Might as well call it unix.go. You're already in package signal. > Done.
	11

	12 CLEANFILES=unix_signals.go
	rsc 2010/01/07 16:30:06 probably CLEANFILES+=unix.go (s/=/+=/) just in cas probably CLEANFILES+=unix.go (s/=/+=/) just in case dsymonds 2010/01/07 22:58:17 Done. Show quoted text On 2010/01/07 16:30:06, rsc wrote: > probably CLEANFILES+=unix.go > (s/=/+=/) just in case > Done.
10	13

11 include ../../../Make.pkg	14 include ../../../Make.pkg

	15

	16 unix_signals.go: ../../syscall/zerrors_$(GOOS)_$(GOARCH).go

	17 @echo "// Automatically generated. Do not edit!" > $@
	rsc 2010/01/07 16:30:06 Please drop all the @. It's important to see what' Please drop all the @. It's important to see what's breaking, and echoing everything is the only way to do that. Also move this into a shell script, so that this is just ./mkunix $^ >$@ \|\| rm -f $@ Then you're not limited to the silly one-line-per-command nonsense of Makefiles. Having done that, make this warning look like the others in syscall: same phrasing and a separate line giving the exact command line. dsymonds 2010/01/07 22:58:17 Done. Show quoted text On 2010/01/07 16:30:06, rsc wrote: > Please drop all the @. > It's important to see what's breaking, and echoing everything is the only way to > do that. > > Also move this into a shell script, so that this is just > > ./mkunix $^ >$@ \|\| rm -f $@ > > Then you're not limited to the silly one-line-per-command nonsense of Makefiles. > > Having done that, make this warning look like the others in syscall: > same phrasing and a separate line giving the exact command line. > Done.
	18 @echo "package signal" >> $@

	19 @echo 'import "syscall"' >> $@

	20 @echo "const (" >> $@

	21 @gawk '/^[ \t]*SIG/ { print "\t" $$1 "\t= UnixSignal(syscall." $$1 ")" } ' $< >> $@
	rsc 2010/01/07 16:30:06 Please drop all the @. It's important to see what' Please drop all the @. It's important to see what's breaking, and echoing everything is the only way to do that. Please also move this into a shell script, so that this is just ./mkunix $^ >$@ \|\| rm -f $@ Then you're not limited to the silly one-line-per-command nonsense of Makefiles. In the script, please avoid gawk, which my Mac doesn't have. Not everyone has awk either, but you can rely on sed: sed -n '/^ SIG/ { s/ .// s/SIG./& = UnixSignal(syscall.&)/p }' zerrors_${GOOS}_${GOARCH}.go dsymonds 2010/01/07 22:58:17 Done. Show quoted text On 2010/01/07 16:30:06, rsc wrote: > Please drop all the @. > It's important to see what's breaking, and echoing everything is the only way to > do that. > > Please also move this into a shell script, so that this is just > > ./mkunix $^ >$@ \|\| rm -f $@ > > Then you're not limited to the silly one-line-per-command nonsense of Makefiles. > > In the script, please avoid gawk, which my Mac doesn't have. > Not everyone has awk either, but you can rely on sed: > > sed -n '/^ SIG/ { > s/ .// > s/SIG./& = UnixSignal(syscall.&)/p > }' zerrors_${GOOS}_${GOARCH}.go > > Done.
	22 @echo ")" >> $@

OLD	NEW

« no previous file with comments | « .hgignore ('k') | src/pkg/os/signal/signal_test.go » ('j') | no next file with comments »