Issue 183130: [SHINDIG-1257] Allow extensions to JsonRpcHandler, plus bug fixes

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 183130: [SHINDIG-1257] Allow extensions to JsonRpcHandler, plus bug fixes

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 3 months ago by Jon Weygandt

Modified:
9 years, 4 months ago

Reviewers:
shindig.remailer

Base URL:
http://svn.apache.org/repos/asf/incubator/shindig/trunk/

Visibility:
Public.

Patch Set 1 #

Total comments: 1

Created: 14 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -20 lines)			Patch
		java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/JsonRpcHandler.java	View		8 chunks	+29 lines, -18 lines	1 comment	Download
		java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/JsonRpcHandlerTest.java	View		2 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Jon Weygandt

14 years, 3 months ago (2010-01-06 19:32:35 UTC) #2

http://codereview.appspot.com/183130/diff/1/3
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/JsonRpcHandler.java
(right):

http://codereview.appspot.com/183130/diff/1/3#newcode144
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/JsonRpcHandler.java:144:
} catch (Exception e) {
Another bug fix, not described in the JIRA bug: During runtime it is possible
for RuntimeExceptions to be thrown. The old code only caught checked exceptions.
The RuntimeExceptions causes the loop above to throw a "Processing interrupted"
exception rather than simply place the error in the Json metadata, which caused
the entire metadata request to fail because of a single gadget. This catch will
prevent that.

Expand All Messages | Collapse All Messages