Issue 183096: Add flag to enable bitmap strikes.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 183096: Add flag to enable bitmap strikes.

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 9 months ago by agl

Modified:
14 years, 9 months ago

Reviewers:
reed

Visibility:
Public.

Description

Add flag to enable bitmap strikes.

Patch Set 1 #

Created: 14 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -7 lines)			Patch
M	include/core/SkPaint.h	View	3 chunks	+14 lines, -2 lines	0 comments	Download
M	include/core/SkScalerContext.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/core/SkPaint.cpp	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	src/ports/SkFontHost_FreeType.cpp	View	2 chunks	+4 lines, -5 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

reed

What do you mean by kBitmapStrikes? Embedded bitmaps inside the font? If so, how about ...

14 years, 9 months ago (2009-12-31 01:17:42 UTC) #2

agl

14 years, 9 months ago (2010-01-04 18:25:46 UTC) #3

On 2009/12/31 01:17:42, reed wrote:
> What do you mean by kBitmapStrikes? Embedded bitmaps inside the font? If so,
how
> about calling it EmbeddedBitmapText, to close match the meaning (to me
anyway),
> and the pattern of adding Text after the name for flags related to text/fonts.

Renamed.

> It looks like you have an unrelated change in freetype, adding the LCD formats
> to an if-statement, which seems fine.

It's actually related. Once you enable bitmap strikes, you need to add these LCD
formats to the if statement otherwise we can't convert the bitmaps to masks and
we hit an assert.

Thanks for the review. Landing now.

AGL

Expand All Messages | Collapse All Messages