Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(658)

Issue 183048: Clean up lilypond-book snippet formatting and file name hashing (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 4 months ago by John Mandereau
Modified:
11 years, 9 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Clean up lilypond-book snippet formatting and file name hashing process_snippets(): eliminate duplicates in snippet lists written in snippet-names-*.ly, which fixes issue #867. LilyPondSnippet.get_checksum(): reintroduce in hashing fragment options that matter for processing by lilypond, which had be neglected since commit 4c5a581ca25398669b9ecbc7a606febb09e60214. LilyPondSnippet.basename(): remove duplicated truncation of hash hex value. Ly snippet formatting: sort fragment options for more predictable and repetable output, and don't write fragment options that don't have an impact of lilypond processing. Fix a few other nitpicks (e.g. comments).

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -16 lines) Patch
M scripts/lilypond-book.py View 8 chunks +48 lines, -16 lines 0 comments Download

Messages

Total messages: 2
John Mandereau
14 years, 4 months ago (2009-12-24 01:51:04 UTC) #1
Colin Campbell
12 years, 10 months ago (2011-06-27 01:44:13 UTC) #2
I believe, since issue 867 is marked verified, that this could be closed, John.

cheers,
Colin Campbell
Bug Squad
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b