Issue 22: Adding psutil 2.X support to the process info library.

These files are missing unit tests:
 + plaso/multi_processing/process_info.py + utils/check_dependencies.py

[Joachim Metz, 2014-12-06 07:54:29]

Some nits.

https://codereview.appspot.com/181610043/diff/1/plaso/multi_processing/proces...
File plaso/multi_processing/process_info.py (right):

https://codereview.appspot.com/181610043/diff/1/plaso/multi_processing/proces...
plaso/multi_processing/process_info.py:59: self._psutil_old_version = True
please change psutil_old_version to psutil_pre_v2 or just store the version
number once and do version < (2, 0, 0)

IMO this makes it more clear that which versions this applies to.

https://codereview.appspot.com/181610043/diff/1/utils/check_dependencies.py
File utils/check_dependencies.py (left):

https://codereview.appspot.com/181610043/diff/1/utils/check_dependencies.py#o...
utils/check_dependencies.py:308: 'psutil', '__version__', '1.2.1',
maximum_version='1.2.1'):
Shouldn't there be a check for version 2 as well?

[kiddi, 2014-12-06 18:28:54]

done

https://codereview.appspot.com/181610043/diff/1/plaso/multi_processing/proces...
File plaso/multi_processing/process_info.py (right):

https://codereview.appspot.com/181610043/diff/1/plaso/multi_processing/proces...
plaso/multi_processing/process_info.py:59: self._psutil_old_version = True
On 2014/12/06 07:54:29, Joachim Metz wrote:
> please change psutil_old_version to psutil_pre_v2 or just store the version
> number once and do version < (2, 0, 0)
> 
> IMO this makes it more clear that which versions this applies to.

Done.

https://codereview.appspot.com/181610043/diff/1/utils/check_dependencies.py
File utils/check_dependencies.py (left):

https://codereview.appspot.com/181610043/diff/1/utils/check_dependencies.py#o...
utils/check_dependencies.py:308: 'psutil', '__version__', '1.2.1',
maximum_version='1.2.1'):
On 2014/12/06 07:54:29, Joachim Metz wrote:
> Shouldn't there be a check for version 2 as well?

is that really needed? this works with all version above 1.2.1 (last of 1.X) and
so far all of version 2.x

[kiddi, 2014-12-06 18:29:54]

Code updated.

[Joachim Metz, 2014-12-06 18:36:37]

LGTM

https://codereview.appspot.com/181610043/diff/1/utils/check_dependencies.py
File utils/check_dependencies.py (left):

https://codereview.appspot.com/181610043/diff/1/utils/check_dependencies.py#o...
utils/check_dependencies.py:308: 'psutil', '__version__', '1.2.1',
maximum_version='1.2.1'):
On 2014/12/06 18:28:54, kiddi wrote:
> On 2014/12/06 07:54:29, Joachim Metz wrote:
> > Shouldn't there be a check for version 2 as well?
> 
> is that really needed? this works with all version above 1.2.1 (last of 1.X)
and
> so far all of version 2.x

removing the max version works for me as well.

[kiddi, 2014-12-08 22:11:42]

Code Submitted.