Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(14891)

Issue 181118: Use the same internal model for m2m and o2m (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 3 months ago by ced
Modified:
14 years, 3 months ago
Reviewers:
bch, udono, yangoon1
Visibility:
Public.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix default value and on_change #

Patch Set 3 : Remove print #

Patch Set 4 : Allow to use switch widget between o2m and m2m #

Patch Set 5 : Restore get_eval for M2M #

Total comments: 1

Patch Set 6 : Fix set_default for boolean value #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -107 lines) Patch
M tryton/gui/window/view_form/model/field.py View 1 2 3 4 5 6 chunks +56 lines, -71 lines 0 comments Download
M tryton/gui/window/view_form/model/record.py View 2 chunks +3 lines, -2 lines 0 comments Download
M tryton/gui/window/view_form/view/form_gtk/interface.py View 1 chunk +1 line, -1 line 0 comments Download
M tryton/gui/window/view_form/view/form_gtk/many2many.py View 1 2 3 chunks +18 lines, -27 lines 0 comments Download
M tryton/gui/window/view_form/view/list_gtk/parser.py View 2 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 11
ced
14 years, 3 months ago (2010-01-03 17:28:31 UTC) #1
yangoon1
http://codereview.appspot.com/181118/diff/1/2 File tryton/gui/window/view_form/model/field.py (left): http://codereview.appspot.com/181118/diff/1/2#oldcode419 tryton/gui/window/view_form/model/field.py:419: def rec_name(self, model): rec_name exists in old M2M, but ...
14 years, 3 months ago (2010-01-03 18:04:05 UTC) #2
ced
14 years, 3 months ago (2010-01-03 18:33:22 UTC) #3
ced
14 years, 3 months ago (2010-01-03 18:34:16 UTC) #4
bch
On 2010/01/03 18:34:16, ced wrote: > OK for me
14 years, 3 months ago (2010-01-04 09:14:01 UTC) #5
ced
14 years, 3 months ago (2010-01-05 13:05:38 UTC) #6
udono
First test works good for me. I will test it now for longer. A question ...
14 years, 3 months ago (2010-01-05 14:50:48 UTC) #7
ced
On 2010/01/05 14:50:48, udo.spallek wrote: > First test works good for me. I will test ...
14 years, 3 months ago (2010-01-05 15:13:57 UTC) #8
ced
14 years, 3 months ago (2010-01-06 12:12:11 UTC) #9
udono
http://codereview.appspot.com/181118/diff/17/18 File tryton/gui/window/view_form/model/field.py (right): http://codereview.appspot.com/181118/diff/17/18#newcode468 tryton/gui/window/view_form/model/field.py:468: when value is type boolean, it breaks with: ERROR:common.message:Traceback ...
14 years, 3 months ago (2010-01-06 13:27:09 UTC) #10
ced
14 years, 3 months ago (2010-01-06 13:48:32 UTC) #11

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b