Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(768)

Issue 181109: Add basic scheme programmable engravers. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 2 months ago by hanwenn
Modified:
9 years ago
Reviewers:
joeneeman, dak
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Add basic scheme programmable engravers. * input/regression/scheme-engraver.ly shows a basic example. * extend \consists syntax to accept an alist of callables. * add Scheme_engraver which is the C++ glue to the Scheme callables. * Make get_listener_ in translator_listener_record also pass the listened class, so we can use generic infrastructure for hooking scheme functions to event listeners. * add scheme bindings: - ly:translator-context - ly:context-moment - ly:engraver-make-grob

Patch Set 1 #

Patch Set 2 : polish #

Total comments: 6

Patch Set 3 : Joe's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+598 lines, -46 lines) Patch
A input/regression/scheme-engraver.ly View 1 2 1 chunk +76 lines, -0 lines 0 comments Download
M lily/axis-group-engraver.cc View 1 chunk +6 lines, -1 line 0 comments Download
M lily/context-def.cc View 1 chunk +1 line, -5 lines 0 comments Download
M lily/context-scheme.cc View 1 2 1 chunk +12 lines, -0 lines 0 comments Download
M lily/engraver.cc View 1 3 chunks +17 lines, -4 lines 0 comments Download
A lily/engraver-scheme.cc View 1 chunk +40 lines, -0 lines 0 comments Download
M lily/include/axis-group-engraver.hh View 1 chunk +2 lines, -0 lines 0 comments Download
M lily/include/engraver.hh View 2 chunks +3 lines, -1 line 0 comments Download
M lily/include/lily-proto.hh View 1 chunk +1 line, -0 lines 0 comments Download
A lily/include/scheme-engraver.hh View 1 2 1 chunk +79 lines, -0 lines 0 comments Download
M lily/include/translator.hh View 1 10 chunks +32 lines, -13 lines 0 comments Download
lily/include/translator.icc View 4 chunks +19 lines, -6 lines 0 comments Download
M lily/parser.yy View 1 1 chunk +11 lines, -0 lines 0 comments Download
A lily/scheme-engraver.cc View 1 1 chunk +256 lines, -0 lines 0 comments Download
M lily/translator.cc View 1 5 chunks +9 lines, -8 lines 0 comments Download
M lily/translator-group.cc View 1 2 3 chunks +22 lines, -8 lines 0 comments Download
M lily/translator-scheme.cc View 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 3
joeneeman
Neat! http://codereview.appspot.com/181109/diff/17/21 File lily/context-scheme.cc (right): http://codereview.appspot.com/181109/diff/17/21#newcode26 lily/context-scheme.cc:26: // TODO: naming - should use now? I ...
14 years, 2 months ago (2010-01-02 06:13:54 UTC) #1
hanwenn
seems I have some drafts left :-) https://codereview.appspot.com/181109/diff/17/lily/context-scheme.cc File lily/context-scheme.cc (right): https://codereview.appspot.com/181109/diff/17/lily/context-scheme.cc#newcode26 lily/context-scheme.cc:26: // TODO: ...
9 years ago (2015-03-14 14:48:43 UTC) #2
dak
9 years ago (2015-03-14 15:06:46 UTC) #3
Message was sent while issue was closed.
On 2015/03/14 14:48:43, hanwenn wrote:
> seems I have some drafts left :-)

I am pretty sure that draft beer gets stale after considerably less than five
years.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b