Issue 181068: Thread baseUri through with HTML jobs.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 181068: Thread baseUri through with HTML jobs. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 6 months ago by MikeSamuel

Modified:
16 years, 6 months ago

Reviewers:
Jasvir

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Associate a base URI with HTML and CSS jobs so we can properly resolve URIs. This changes the way Jobs are constructed to carry around a base URI, attaches that info to embedded content, and threads it into the ResolveURIStage and InlineCSSImportsStage. Submitted @3933

Patch Set 1 #

Created: 16 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+314 lines, -213 lines)			Patch
M	src/com/google/caja/opensocial/DefaultGadgetRewriter.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/com/google/caja/plugin/BuildServiceImplementation.java	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/com/google/caja/plugin/Job.java	View	1 chunk	+50 lines, -15 lines	0 comments	Download
M	src/com/google/caja/plugin/Jobs.java	View	2 chunks	+7 lines, -5 lines	0 comments	Download
M	src/com/google/caja/plugin/PluginCompiler.java	View	4 chunks	+11 lines, -4 lines	0 comments	Download
M	src/com/google/caja/plugin/PluginCompilerMain.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/com/google/caja/plugin/stages/CompileHtmlStage.java	View	4 chunks	+19 lines, -9 lines	0 comments	Download
M	src/com/google/caja/plugin/stages/ConsolidateCodeStage.java	View	3 chunks	+3 lines, -2 lines	0 comments	Download
M	src/com/google/caja/plugin/stages/DebuggingSymbolsStage.java	View	3 chunks	+6 lines, -4 lines	0 comments	Download
M	src/com/google/caja/plugin/stages/EmbeddedContent.java	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	src/com/google/caja/plugin/stages/HtmlEmbeddedContentFinder.java	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	src/com/google/caja/plugin/stages/InlineCssImportsStage.java	View	7 chunks	+14 lines, -13 lines	0 comments	Download
M	src/com/google/caja/plugin/stages/LegacyNamespaceFixupStage.java	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/com/google/caja/plugin/stages/OpenTemplateStage.java	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/com/google/caja/plugin/stages/ResolveUriStage.java	View	3 chunks	+27 lines, -14 lines	0 comments	Download
M	src/com/google/caja/plugin/stages/RewriteCssStage.java	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/com/google/caja/plugin/stages/RewriteHtmlStage.java	View	3 chunks	+5 lines, -3 lines	0 comments	Download
M	src/com/google/caja/plugin/stages/SanitizeHtmlStage.java	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/com/google/caja/plugin/stages/ValidateCssStage.java	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/com/google/caja/plugin/stages/ValidateJavascriptStage.java	View	3 chunks	+3 lines, -2 lines	0 comments	Download
M	src/com/google/caja/plugin/templates/TemplateCompiler.java	View	6 chunks	+12 lines, -8 lines	0 comments	Download
M	src/com/google/caja/service/HtmlHandler.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/com/google/caja/demos/benchmarks/BenchmarkRunner.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/com/google/caja/demos/benchmarks/BenchmarkSize.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/com/google/caja/plugin/HtmlCompiledPluginTest.java	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	tests/com/google/caja/plugin/HtmlEmitterTest.java	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	tests/com/google/caja/plugin/stages/CompileHtmlStageTest.java	View	3 chunks	+7 lines, -7 lines	0 comments	Download
M	tests/com/google/caja/plugin/stages/DebuggingSymbolsStageTest.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/com/google/caja/plugin/stages/InlineCssImportsStageTest.java	View	6 chunks	+17 lines, -17 lines	0 comments	Download
M	tests/com/google/caja/plugin/stages/LegacyNamespaceFixupStageTest.java	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	tests/com/google/caja/plugin/stages/OpenTemplateStageTest.java	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/com/google/caja/plugin/stages/PipelineStageTestCase.java	View	3 chunks	+13 lines, -9 lines	0 comments	Download
M	tests/com/google/caja/plugin/stages/ResolveUriStageTest.java	View	1 chunk	+19 lines, -19 lines	0 comments	Download
M	tests/com/google/caja/plugin/stages/RewriteHtmlStageTest.java	View	8 chunks	+56 lines, -55 lines	0 comments	Download
M	tests/com/google/caja/plugin/templates/TemplateCompilerTest.java	View	3 chunks	+8 lines, -6 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages