Issue 18041: Cleander dispatch handling

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 18041: Cleander dispatch handling

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 7 months ago by louiscryan

Modified:
16 years, 7 months ago

Reviewers:
shindig-dev, awiner

Base URL:
http://svn.apache.org/repos/asf/incubator/shindig/trunk/

Visibility:
Public.

Description

Match paths with constant parts prior to parameterized parts. Allow override of RPC method name in Operation annotation Cleanup dispatch code and RestHandler/RpcHandler interfaces

Patch Set 1 #

Total comments: 6

Created: 16 years, 7 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+321 lines, -122 lines)			Patch
../trunk/java/common/src/main/java/org/apache/shindig/protocol/DataServiceServlet.java	View	3 chunks	+5 lines, -5 lines	0 comments	Download
../trunk/java/common/src/main/java/org/apache/shindig/protocol/DefaultHandlerRegistry.java	View	17 chunks	+215 lines, -76 lines	6 comments	Download
../trunk/java/common/src/main/java/org/apache/shindig/protocol/JsonRpcServlet.java	View	3 chunks	+7 lines, -5 lines	0 comments	Download
../trunk/java/common/src/main/java/org/apache/shindig/protocol/Operation.java	View	1 chunk	+6 lines, -0 lines	0 comments	Download
../trunk/java/common/src/main/java/org/apache/shindig/protocol/RestHandler.java	View	1 chunk	+1 line, -1 line	0 comments	Download
../trunk/java/common/src/main/java/org/apache/shindig/protocol/RpcHandler.java	View	2 chunks	+1 line, -3 lines	0 comments	Download
../trunk/java/common/src/test/java/org/apache/shindig/protocol/DefaultHandlerRegistryTest.java	View	9 chunks	+52 lines, -10 lines	0 comments	Download
../trunk/java/common/src/test/java/org/apache/shindig/protocol/TestHandler.java	View	2 chunks	+9 lines, -0 lines	0 comments	Download
../trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/ActivityHandlerTest.java	View	7 chunks	+8 lines, -7 lines	0 comments	Download
../trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/AppDataHandlerTest.java	View	8 chunks	+8 lines, -7 lines	0 comments	Download
../trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/PersonHandlerTest.java	View	8 chunks	+9 lines, -8 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

awiner

Looks good to me. http://codereview.appspot.com/18041/diff/1/11 File ../trunk/java/common/src/main/java/org/apache/shindig/protocol/DefaultHandlerRegistry.java (right): http://codereview.appspot.com/18041/diff/1/11#newcode193 Line 193: sortedSet = Sets.<RestPath>newTreeSet(); <RestPath> ...

16 years, 7 months ago (2009-02-10 23:31:32 UTC) #2

louiscryan

16 years, 7 months ago (2009-02-11 00:44:24 UTC) #3

Changes made, committing

http://codereview.appspot.com/18041/diff/1/11
File
../trunk/java/common/src/main/java/org/apache/shindig/protocol/DefaultHandlerRegistry.java
(right):

http://codereview.appspot.com/18041/diff/1/11#newcode193
Line 193: sortedSet = Sets.<RestPath>newTreeSet();
On 2009/02/10 23:31:32, awiner wrote:
> <RestPath> is unnecessary here

Done.

http://codereview.appspot.com/18041/diff/1/11#newcode286
Line 286: RpcInvocationHandler handler;
On 2009/02/10 23:31:32, awiner wrote:
> final

Done.

http://codereview.appspot.com/18041/diff/1/11#newcode411
Line 411: private String operationPath;
On 2009/02/10 23:31:32, awiner wrote:
> List<Part>, where Part has a PartType and a String?  All these could be made
> final also (albeit with some code tweaks)

Done.

Expand All Messages | Collapse All Messages