Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3747)

Issue 180114: Use different types of events for cueDuring and quoteDuring (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 4 months ago by Reinhold
Modified:
14 years, 4 months ago
Reviewers:
Ian Hulin, carl.d.sorensen
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Use different types of events for cueDuring and quoteDuring Typically, \quoteDuring is supposed to duplicate everything in a voice, while \cueDuring is supposed to only quote the notes, but not e.g. phrasing, slurs, accents, markup, etc. So, this commit adds an additional property quotedCueEventTypes in addition to quotedEventTypes, which allows to quote different types for \cueDuring than for \quoteDuring. By default, \quoteDuring now quotes everything (i.e. StreamEvent), while \cueDuring quotes only notes, rest, ties, beams and tuplets.

Patch Set 1 #

Patch Set 2 : Document the difference between cue/quoteDuring and how to selected the quoted event types #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -13 lines) Patch
M Documentation/notation/staff.itely View 1 6 chunks +48 lines, -6 lines 2 comments Download
A input/regression/quote-cue-event-types.ly View 1 1 chunk +37 lines, -0 lines 0 comments Download
M lily/quote-iterator.cc View 4 chunks +14 lines, -5 lines 0 comments Download
M ly/engraver-init.ly View 1 chunk +3 lines, -1 line 0 comments Download
M scm/define-context-properties.scm View 1 chunk +5 lines, -1 line 1 comment Download

Messages

Total messages: 2
Carl
Reinhold, This looks great! Thanks for doing it. Just two small comments. Carl http://codereview.appspot.com/180114/diff/21/1002 File ...
14 years, 4 months ago (2009-12-22 22:16:02 UTC) #1
Ian Hulin
14 years, 4 months ago (2009-12-22 23:21:26 UTC) #2
Hi Reinhold,
Staff.itely ooks good, apart from one nitpick.  Could you double-check this file
for trailing spaces, please?

Cheers,
Ian

http://codereview.appspot.com/180114/diff/21/1002
File Documentation/notation/staff.itely (right):

http://codereview.appspot.com/180114/diff/21/1002#newcode1139
Documentation/notation/staff.itely:1139: It is possible to adjust which objects
from the original voice are quoted
"It is also possible". . .
(just makes reading it flow better from the previous paragraph)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b