Issue 180095: Fix Tracker 918, Add extra RemoveEmpty*StaffContext functions to support "Frenched" scores

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 180095: Fix Tracker 918, Add extra RemoveEmpty*StaffContext functions to support "Frenched" scores

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 4 months ago by Ian Hulin

Modified:
9 years, 7 months ago

Reviewers:
Neil Puttock

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Fix Tracker 918, Add extra RemoveEmpty*StaffContext functions to support "Frenched" scores with DrumStaff, TabStaff and RhythmicStaff staves. Add new definitions in ly/engraver-int.ly and new regression tests. Fix Tracker 918, Add extra RemoveEmpty*StaffContext functions to support "Frenched" scores with DrumStaff, TabStaff and RhythmicStaff staves. Add new definitions in ly/engraver-int.ly and new regression tests.

Patch Set 1 #

Patch Set 2 : Fix regressions in engraver-init.ly #

Patch Set 3 : Remove regression re Swallow*tranlslator being reinstated #

Created: 14 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+171 lines, -11 lines)			Patch
A	input/regression/hara-kiri-drumstaff.ly	View		1 chunk	+48 lines, -0 lines	0 comments	Download
M	input/regression/hara-kiri-percent-repeat.ly	View		1 chunk	+15 lines, -9 lines	0 comments	Download
A	input/regression/hara-kiri-rhythmicstaff.ly	View		1 chunk	+44 lines, -0 lines	0 comments	Download
A	input/regression/hara-kiri-tabstaff.ly	View		1 chunk	+48 lines, -0 lines	0 comments	Download
M	ly/engraver-init.ly	View	1 2	2 chunks	+16 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Ian Hulin

New patch-set uploaded with regressions in engraver-init.ly fixed. Now OK to push? Cheers, Ian

14 years, 4 months ago (2009-12-21 00:33:59 UTC) #1

Neil Puttock

On 2009/12/21 00:33:59, Ian Hulin wrote: > New patch-set uploaded with regressions in engraver-init.ly fixed. ...

14 years, 4 months ago (2009-12-21 23:34:14 UTC) #2

Ian Hulin

14 years, 4 months ago (2009-12-22 10:41:23 UTC) #3

Hi Neil,

On 21/12/09 23:34, n.puttock@gmail.com wrote:
> On 2009/12/21 00:33:59, Ian Hulin wrote:
>> New patch-set uploaded with regressions in engraver-init.ly fixed.
>
>> Now OK to push?
>
> LGTM, applied.
>
Much obliged,
Have a good Christmas,

Cheers,

Ian

Expand All Messages | Collapse All Messages