Issue 179320043: improve initial estimate of beamed-rest position; issue 472

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 179320043: improve initial estimate of beamed-rest position; issue 472

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 4 months ago by Keith

Modified:
9 years, 4 months ago

Reviewers:
lemzwerg

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

improve initial estimate of beamed-rest position; issue 472

Patch Set 1 #

Total comments: 1

Patch Set 2 : comma instead of ellipses #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -28 lines)			Patch
	M	input/regression/beam-rest-extreme.ly	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	lily/beam.cc	View		3 chunks	+20 lines, -27 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

lemzwerg

9 years, 4 months ago (2014-11-24 07:25:24 UTC) #1

LGTM.

https://codereview.appspot.com/179320043/diff/1/lily/beam.cc
File lily/beam.cc (right):

https://codereview.appspot.com/179320043/diff/1/lily/beam.cc#newcode1357
lily/beam.cc:1357: /* Estimate the closest beam to be four positions away from
the heads.. */
I always notice the most unimportant things, e.g. two final dots... :-)

Expand All Messages | Collapse All Messages