Issue 178970043: ICU ticket #11336: UnicodeString: recombine stack buffer arrays

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 178970043: ICU ticket #11336: UnicodeString: recombine stack buffer arrays (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 1 month ago by markus.icu

Modified:
8 years, 7 months ago

Reviewers:
andy.heninger

CC:
srl_icu-project.org, kcc1

Base URL:
http://source.icu-project.org/repos/icu/icu/trunk

Visibility:
Public.

More Reviews

Description

recombine stack buffer arrays; one int16_t for short length & flags

Patch Set 1 #

Total comments: 1

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+197 lines, -183 lines)			Patch
M	source/common/unicode/unistr.h	View	11 chunks	+101 lines, -53 lines	0 comments	Download
M	source/common/unistr.cpp	View	29 chunks	+80 lines, -104 lines	0 comments	Download
M	source/common/unistr_case.cpp	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	source/common/unistr_cnv.cpp	View	6 chunks	+11 lines, -21 lines	0 comments	Download
M	source/common/unistr_props.cpp	View	1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

andy.heninger

10 years, 1 month ago (2014-11-19 20:30:01 UTC) #2

https://codereview.appspot.com/178970043/diff/1/source/common/unistr_props.cpp
File source/common/unistr_props.cpp (right):

https://codereview.appspot.com/178970043/diff/1/source/common/unistr_props.cp...
source/common/unistr_props.cpp:4: *   Copyright (C) 1999-2014, International
Business Machines
No other changes in file, can revert this.

Expand All Messages | Collapse All Messages