Issue 1774043: python8954: wininst regression: errors when building on linux

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1774043: python8954: wininst regression: errors when building on linux

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 5 months ago by techtonik

Modified:
13 years, 11 months ago

Reviewers:
Ezio Melotti

Base URL:
http://svn.python.org/view/*checkout*/python/trunk/Lib/distutils/command/

Visibility:
Public.

Patch Set 2 : reupload correct version #

Total comments: 4

Patch Set 3 : Tidy up comments per Ezio notes #

Created: 13 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -9 lines)			Patch
	M	bdist_wininst.py	View	1 2	6 chunks	+32 lines, -9 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Ezio Melotti

http://codereview.appspot.com/1774043/diff/2001/3001 File bdist_wininst.py (right): http://codereview.appspot.com/1774043/diff/2001/3001#newcode12 bdist_wininst.py:12: the same compiler python itself is compiled with, i.e. ...

14 years, 5 months ago (2010-07-12 11:44:17 UTC) #1

techtonik

13 years, 11 months ago (2011-01-09 16:58:59 UTC) #2

Done.

http://codereview.appspot.com/1774043/diff/2001/bdist_wininst.py
File bdist_wininst.py (right):

http://codereview.appspot.com/1774043/diff/2001/bdist_wininst.py#newcode12
bdist_wininst.py:12: the same compiler python itself is compiled with, i.e.
Visual Studio.
On 2010/07/12 11:44:17, Ezio Melotti wrote:
> Python should be capitalized, here, in the list and a few lines later. Same
for
> Windows.

Done.

http://codereview.appspot.com/1774043/diff/2001/bdist_wininst.py#newcode78
bdist_wininst.py:78: # win-amd64 (64bit Windows on AMD64 (aka x86_64, Intel64,
EM64T, etc)
On 2010/07/12 11:44:17, Ezio Melotti wrote:
> Odd number of parentheses.

Done.

Expand All Messages | Collapse All Messages