Issue 176050: Clear fDeviceCMDirty

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 176050: Clear fDeviceCMDirty (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 11 months ago by agl

Modified:
14 years, 11 months ago

Reviewers:
reed

Visibility:
Public.

Description

Clear fDeviceCMDirty

Patch Set 1 #

Created: 14 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	src/core/SkCanvas.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

agl

The Chromium builders just starting throwing this up: Invalid read of size 1 SkCanvas::updateDeviceCMCache() (third_party/skia/src/core/SkCanvas.cpp:530) ...

14 years, 11 months ago (2009-12-11 21:13:06 UTC) #1

reed

14 years, 11 months ago (2009-12-11 21:16:40 UTC) #2

LGTM

On 2009/12/11 21:13:06, agl wrote:
> The Chromium builders just starting throwing this up:
> 
> Invalid read of size 1
>   SkCanvas::updateDeviceCMCache() (third_party/skia/src/core/SkCanvas.cpp:530)
>   SkDrawIter::SkDrawIter(SkCanvas*, bool)
> (third_party/skia/src/core/SkCanvas.cpp:218)
>   SkCanvas::LayerIter::LayerIter(SkCanvas*, bool)
> (third_party/skia/src/core/SkCanvas.cpp:1406)
>   skia::PlatformCanvas::getTopPlatformDevice() const
> (skia/ext/platform_canvas.cc:17)
>   TestShell::DumpImage(skia::PlatformCanvas*, std::basic_string<wchar_t,
> std::char_traits<wchar_t>, std::allocator<wchar_t> > const&,
> std::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)
> (webkit/tools/test_shell/test_shell.cc:282)
>   TestShell::Dump(TestShell*) (webkit/tools/test_shell/test_shell.cc:269)
>   TestShell::TestFinished() (webkit/tools/test_shell/test_shell_gtk.cc:399)
>   LayoutTestController::WorkQueue::ProcessWorkSoon()
> (webkit/tools/test_shell/layout_test_controller.cc:170)
>   LayoutTestController::LocationChangeDone()
> (webkit/tools/test_shell/layout_test_controller.cc:484)
>   TestWebViewDelegate::LocationChangeDone(WebKit::WebFrame*)
> (webkit/tools/test_shell/test_webview_delegate.cc:1048)
> 
> I couldn't see where fDeviceCMDirty was cleared, so I threw together this
patch.

Expand All Messages | Collapse All Messages