Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2149)

Issue 174610043: Issue 4205: Improve part combiner's rest analysis (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 5 months ago by Dan Eble
Modified:
8 years, 11 months ago
Reviewers:
Keith
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Issue 4205: Improve part combiner's rest analysis Rests must begin and end simultaneously to be merged into the shared voice. Rests, skips, and multi-measure rests are kept apart even if they begin and end simultaneously. This does not produce ideal output in every case, but it avoids producing musical nonsense.

Patch Set 1 #

Patch Set 2 : Simplify and add regtest #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -6 lines) Patch
A input/regression/part-combine-mmrest-after-apart-silence.ly View 1 1 chunk +18 lines, -0 lines 0 comments Download
A input/regression/part-combine-mmrest-shared.ly View 1 chunk +26 lines, -0 lines 0 comments Download
A input/regression/part-combine-silence.ly View 1 1 chunk +31 lines, -0 lines 0 comments Download
A input/regression/part-combine-silence-mixed.ly View 1 chunk +18 lines, -0 lines 0 comments Download
M scm/part-combiner.scm View 1 2 chunks +58 lines, -6 lines 2 comments Download

Messages

Total messages: 4
Dan Eble
9 years, 5 months ago (2014-11-24 05:12:03 UTC) #1
Dan Eble
Simplify and add regtest
9 years, 5 months ago (2014-11-26 04:30:57 UTC) #2
Keith
I noticed the same bug with rests and skips. I'm using the patch below with ...
8 years, 11 months ago (2015-05-13 04:55:23 UTC) #3
Dan Eble
8 years, 11 months ago (2015-05-17 02:55:47 UTC) #4
Message was sent while issue was closed.
On 2015/05/13 04:55:23, Keith wrote:
> I noticed the same bug with rests and skips.  I'm using the patch below with
> success on my own music, but I haven't tried it on the regtest suite yet.

Thanks.  You've given me a push, but I think this calls for some more
significant changes to handle same-part multi-measure rests and skips as well. 
I'll work on it.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b