Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1383)

Issue 174073: Fix #628 and allow \note(-by-number) to work with all head styles. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 4 months ago by Neil Puttock
Modified:
14 years, 4 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Fix #628 and allow \note(-by-number) to work with all head styles. * move glyph-selection code from note-head::calc-glyph-name into separate function so it can be accessed by \note and \note-by-number * in \note-by-number, check validity of glyph-name, returning default head style if string is empty

Patch Set 1 #

Patch Set 2 : Add regression tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -59 lines) Patch
A input/regression/markup-note-grob-style.ly View 1 chunk +20 lines, -0 lines 0 comments Download
A input/regression/markup-note-styles.ly View 1 chunk +38 lines, -0 lines 0 comments Download
M scm/define-markup-commands.scm View 4 chunks +40 lines, -22 lines 0 comments Download
M scm/output-lib.scm View 1 chunk +43 lines, -37 lines 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b