Issue 17053: Fix for using upload.py with bazaar based on #14053

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 17053: Fix for using upload.py with bazaar based on #14053

Can't Edit
Can't Publish+Mail
Start Review

Created:
17 years, 4 months ago by muffinresearch

Modified:
2 years, 7 months ago

Reviewers:

Base URL:
http://rietveld.googlecode.com/svn/trunk/static/

Visibility:
Public.

Patch Set 1 #

Total comments: 3

Patch Set 2 : update to trunk version of upload.py #

Patch Set 3 : Better review based on diff on #14053 #

Created: 17 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -8 lines)			Patch
	M	static/upload.py	View		7 chunks	+38 lines, -8 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

muffinresearch

This is the explanation for the differences between this and #14053 http://codereview.appspot.com/17053/diff/1/2 File upload.py (right): ...

17 years, 4 months ago (2009-02-12 23:16:07 UTC) #1

muffinresearch

17 years, 3 months ago (2009-02-18 12:16:58 UTC) #2

Patch Set 3 is a better review as it's a diff on #14053. I've also made a
correction for an issue where bzr root returns within an svn checkout.

See: http://codereview.appspot.com/17053/diff/6/1003

Expand All Messages | Collapse All Messages