Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(919)

Issue 1697056: Issue 1060 -- add Funk and Walker noteheads to shape notes (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 8 months ago by Carl
Modified:
13 years, 6 months ago
Reviewers:
Neil Puttock
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Issue 1060 -- add Funk and Walker noteheads to shape notes Add a series of Funk and Walker note heads to mf/feta-noteheads.mf Add new commands \funkHeads, \funkHeadsMinor, \walkerHeads, and \walkerHeadsMinor Add regression test for \funkHeads and \walkerHeads Update Notation to reflect the addition of \funkHeads and \walkerHeads

Patch Set 1 : Fix 1060 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+1152 lines, -93 lines) Patch
M Documentation/notation/pitches.itely View 5 chunks +31 lines, -2 lines 0 comments Download
A input/regression/note-head-funk.ly View 1 chunk +15 lines, -0 lines 0 comments Download
A input/regression/note-head-walker.ly View 1 chunk +20 lines, -0 lines 0 comments Download
M ly/property-init.ly View 1 chunk +9 lines, -2 lines 0 comments Download
M mf/feta-noteheads.mf View 25 chunks +1077 lines, -89 lines 6 comments Download

Messages

Total messages: 3
Carl
I've created a patch to add Funk and Walker noteheads to the shape note capability ...
13 years, 8 months ago (2010-07-28 19:32:50 UTC) #1
Neil Puttock
LGTM. http://codereview.appspot.com/1697056/diff/2001/3005 File mf/feta-noteheads.mf (right): http://codereview.appspot.com/1697056/diff/2001/3005#newcode1013 mf/feta-noteheads.mf:1013: % (thick_factor - 0.5)* pen_thickness or by (thick_factor ...
13 years, 7 months ago (2010-08-26 23:08:02 UTC) #2
Carl
13 years, 6 months ago (2010-09-10 03:33:47 UTC) #3
Thanks for the review.

http://codereview.appspot.com/1697056/diff/2001/mf/feta-noteheads.mf
File mf/feta-noteheads.mf (right):

http://codereview.appspot.com/1697056/diff/2001/mf/feta-noteheads.mf#newcode1013
mf/feta-noteheads.mf:1013: %   (thick_factor - 0.5)* pen_thickness   or by
On 2010/08/26 23:08:02, Neil Puttock wrote:
> (thick_factor - 0.5) * pen_thickness or by 

Done.

http://codereview.appspot.com/1697056/diff/2001/mf/feta-noteheads.mf#newcode2004
mf/feta-noteheads.mf:2004: save path_a, path_b, path_c, path_d;
On 2010/08/26 23:08:02, Neil Puttock wrote:
> indent

Done.

http://codereview.appspot.com/1697056/diff/2001/mf/feta-noteheads.mf#newcode2207
mf/feta-noteheads.mf:2207: %       Rectcangle head
On 2010/08/26 23:08:02, Neil Puttock wrote:
> Rectangle

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b