Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3409)

Issue 169690043: Issue 4099: Partcombine warning about simultaneous breathing (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 4 months ago by dak
Modified:
8 years, 4 months ago
Reviewers:
Dan Eble
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Issue 4099: Partcombine warning about simultaneous breathing This moves the default midi-length definition of BreathingEvent to define-music-types: it does not make sense to put default settings in the music event itself.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -10 lines) Patch
M ly/music-functions-init.ly View 1 chunk +1 line, -9 lines 0 comments Download
M scm/define-music-callbacks.scm View 1 chunk +11 lines, -0 lines 0 comments Download
M scm/define-music-types.scm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1
Dan Eble
9 years, 4 months ago (2014-11-18 01:25:04 UTC) #1
FWIW, I reviewed this and I think I understand it.  Thanks for fixing the
problem.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b