Issue 1694041: Fix 1031.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1694041: Fix 1031. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 10 months ago by joeneeman

Modified:
13 years, 9 months ago

Reviewers:
Patrick McCarty

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Fix 1031. Prevent ly:beam::rest-collision-callback (which is used in the calculation of a rest's Y-offset) from asking for the rest's Y-offset.

Created: 13 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -33 lines)			Patch
M	lily/beam.cc	View	1 chunk	+2 lines, -6 lines	0 comments	Download
M	lily/include/rest-collision.hh	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	lily/rest-collision.cc	View	3 chunks	+7 lines, -26 lines	0 comments	Download

Total messages: 1

Patrick McCarty

13 years, 10 months ago (2010-06-17 18:29:06 UTC) #1

Hi Joe,

From what I can tell, LGTM.  `make check' is okay, and I can't reproduce the
erroneous offset anymore.