Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(571)

Issue 169290045: Issue 4191: add \first-visible markup command (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 4 months ago by Dan Eble
Modified:
9 years, 4 months ago
Reviewers:
dak
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Add a \first-visible markup command which uses the first argument that produces a non-empty stencil and ignores the rest. This has been useful in the score headers for collections of songs in which I wanted to provide the composer's name if known, otherwise the name of the original publication, but not both, e.g. \first-visible { \fromproperty #'header:composer \italic \fromproperty #'header:musicPublication } This will also be useful in the conversion of time signatures from C++ to Scheme.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Handle markup list commands as arguments to \or #

Total comments: 1

Patch Set 3 : Simplify as suggested #

Total comments: 2

Patch Set 4 : Factor out false-if-empty #

Patch Set 5 : Rename to \first-visible #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -0 lines) Patch
A input/regression/markup-first-visible.ly View 1 2 3 4 1 chunk +87 lines, -0 lines 0 comments Download
M scm/define-markup-commands.scm View 1 2 3 4 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 14
Dan Eble
9 years, 4 months ago (2014-11-08 20:57:05 UTC) #1
dak
https://codereview.appspot.com/169290045/diff/1/scm/define-markup-commands.scm File scm/define-markup-commands.scm (right): https://codereview.appspot.com/169290045/diff/1/scm/define-markup-commands.scm#newcode1175 scm/define-markup-commands.scm:1175: (let ((stencil (interpret-markup layout props (car args)))) I don't ...
9 years, 4 months ago (2014-11-11 09:29:05 UTC) #2
Dan Eble
On 2014/11/11 09:29:05, dak wrote: > Not every markup list is a Scheme list of ...
9 years, 4 months ago (2014-11-12 02:21:41 UTC) #3
Dan Eble
Handle markup list commands as arguments to \or
9 years, 4 months ago (2014-11-12 04:38:48 UTC) #4
dak
On 2014/11/12 02:21:41, Dan Eble wrote: > On 2014/11/11 09:29:05, dak wrote: > > Not ...
9 years, 4 months ago (2014-11-12 06:34:46 UTC) #5
dak
https://codereview.appspot.com/169290045/diff/20001/scm/define-markup-commands.scm File scm/define-markup-commands.scm (right): https://codereview.appspot.com/169290045/diff/20001/scm/define-markup-commands.scm#newcode1183 scm/define-markup-commands.scm:1183: (interpret-markup-list layout props l)))) I'd not do all of ...
9 years, 4 months ago (2014-11-12 06:40:45 UTC) #6
dak
On 2014/11/12 06:40:45, dak wrote: > https://codereview.appspot.com/169290045/diff/20001/scm/define-markup-commands.scm > File scm/define-markup-commands.scm (right): > > https://codereview.appspot.com/169290045/diff/20001/scm/define-markup-commands.scm#newcode1183 > ...
9 years, 4 months ago (2014-11-12 06:58:19 UTC) #7
Dan Eble
On 2014/11/12 06:58:19, dak wrote: > Actually, if you want to go really nuts, instead ...
9 years, 4 months ago (2014-11-12 11:37:41 UTC) #8
dak
On 2014/11/12 11:37:41, Dan Eble wrote: > On 2014/11/12 06:58:19, dak wrote: > > Actually, ...
9 years, 4 months ago (2014-11-12 12:20:00 UTC) #9
Dan Eble
Simplify as suggested
9 years, 4 months ago (2014-11-13 02:33:37 UTC) #10
Dan Eble
https://codereview.appspot.com/169290045/diff/40001/scm/define-markup-commands.scm File scm/define-markup-commands.scm (right): https://codereview.appspot.com/169290045/diff/40001/scm/define-markup-commands.scm#newcode2404 scm/define-markup-commands.scm:2404: "Use @var{size} as the absolute font size (in points) ...
9 years, 4 months ago (2014-11-13 02:36:49 UTC) #11
dak
https://codereview.appspot.com/169290045/diff/40001/scm/define-markup-commands.scm File scm/define-markup-commands.scm (right): https://codereview.appspot.com/169290045/diff/40001/scm/define-markup-commands.scm#newcode1173 scm/define-markup-commands.scm:1173: (or Maybe put a (define (false-if-empty stencil) ...) here? ...
9 years, 4 months ago (2014-11-13 06:57:39 UTC) #12
Dan Eble
Factor out false-if-empty
9 years, 4 months ago (2014-11-15 03:48:17 UTC) #13
Dan Eble
9 years, 4 months ago (2014-11-15 14:17:59 UTC) #14
Rename to \first-visible
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b