Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(211)

Issue 1692051: Added an option for specifying language specification in preparation for supp... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 4 months ago by Alok Priyadarshi
Modified:
14 years, 4 months ago
Reviewers:
kbr1, dgkoch
CC:
angleproject-review_googlegroups.com
Base URL:
http://angleproject.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Added an option for specifying language specification in preparation for supporting WebGL in addition to GLES2. This CL just replaces unused debugOptions variable with EShSpec variable. BUG=11

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -21 lines) Patch
M include/GLSLANG/ShaderLang.h View 2 chunks +10 lines, -1 line 0 comments Download
M samples/translator/translator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/CodeGenGLSL.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/CodeGenHLSL.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/ShHandle.h View 3 chunks +3 lines, -2 lines 0 comments Download
M src/compiler/ShaderLang.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/TranslatorGLSL.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/compiler/TranslatorGLSL.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M src/compiler/TranslatorHLSL.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/compiler/TranslatorHLSL.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/libGLESv2/Shader.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
Alok Priyadarshi
14 years, 4 months ago (2010-07-15 19:25:09 UTC) #1
kbr1
LGTM
14 years, 4 months ago (2010-07-15 23:38:59 UTC) #2
dgkoch
14 years, 4 months ago (2010-07-16 00:14:44 UTC) #3
no issues here

Daniel
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b