Hm, it looks like I'm missing something; if I put a xcode_config in a configuration ...
14 years, 9 months ago
(2010-06-22 22:49:24 UTC)
#2
Hm, it looks like I'm missing something; if I put a xcode_config in a
configuration in a gypi, then use that in a .gyp in another directory, the
magical path fix-up isn't happening. Is there an incantation I need in this
patch to teach gyp that xcode_config needs fixing up?
On 2010/06/22 22:49:24, stuartmorgan wrote: > Is there an incantation I need in this patch ...
14 years, 9 months ago
(2010-06-22 23:00:45 UTC)
#3
On 2010/06/22 22:49:24, stuartmorgan wrote:
> Is there an incantation I need in this patch to teach gyp that
> xcode_config needs fixing up?
Never mind, I found the incantation :)
lgtm, but let mark give it blessing before it lands. It's been a while since ...
14 years, 9 months ago
(2010-06-23 12:20:15 UTC)
#5
lgtm, but let mark give it blessing before it lands.
It's been a while since I looked, isn't there a way to do some setting at the
project level instead of target (I think we did that for SDKs and build output
dir), does it make sense support xcconfigs there also?
LGTM, but… There is a way to set project-wide settings. The comment by the code ...
14 years, 9 months ago
(2010-06-23 14:04:41 UTC)
#6
LGTM, but…
There is a way to set project-wide settings. The comment by the code that makes
this possible describes it and says why we don’t like to do it much, but we do
use this feature in Chrome. See the very end of build/common.gypi, where there’s
an xcode_settings block with a comment saying NOT TO ADD NEW THINGS THERE unless
they’re really necessary.
You can do the same thing there with xcode_config[_file] that we’ve already got
for xcode_settings.
http://codereview.appspot.com/1687044/diff/4001/5002
File pylib/gyp/generator/xcode.py (right):
http://codereview.appspot.com/1687044/diff/4001/5002#newcode155
pylib/gyp/generator/xcode.py:155: # Set user-specified project-wide build
settings. This is intended to be
Look here.
http://codereview.appspot.com/1687044/diff/4001/5002#newcode1126
pylib/gyp/generator/xcode.py:1126: if 'xcode_config' in configuration:
I prefer xcode_config_file. xcode_config is easily confused with xcode_settings.
Using a proper _file name means that you don’t need to special-case it as a
generator-specific generator_additional_path_section.
The support for project-wide settings may be inflexible enough for your needs: we currently only ...
14 years, 9 months ago
(2010-06-23 14:06:40 UTC)
#7
The support for project-wide settings may be inflexible enough for your needs:
we currently only support a single setting across all configurations, but you
may want separate .xcconfigs for various configurations.
On 2010/06/23 14:06:40, Mark Mentovai wrote: > The support for project-wide settings may be inflexible ...
14 years, 9 months ago
(2010-06-23 14:51:46 UTC)
#8
On 2010/06/23 14:06:40, Mark Mentovai wrote:
> The support for project-wide settings may be inflexible enough for your needs
It is, so I didn't add it. If anyone ever needs it, we can alway revisit it
then.
http://codereview.appspot.com/1687044/diff/4001/5002
File pylib/gyp/generator/xcode.py (right):
http://codereview.appspot.com/1687044/diff/4001/5002#newcode1126
pylib/gyp/generator/xcode.py:1126: if 'xcode_config' in configuration:
On 2010/06/23 14:04:41, Mark Mentovai wrote:
> I prefer xcode_config_file.
Done; you'll want to update the language spec page, since that's where I got the
name xcode_config.
Issue 1687044: Add xcode_config support
(Closed)
Created 14 years, 9 months ago by stuartmorgan
Modified 14 years, 8 months ago
Reviewers: thomasvl, Mark Mentovai
Base URL: http://gyp.googlecode.com/svn/trunk/
Comments: 3