Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(252)

Issue 1687044: Add xcode_config support (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 9 months ago by stuartmorgan
Modified:
14 years, 8 months ago
Reviewers:
Mark Mentovai, thomasvl
Base URL:
http://gyp.googlecode.com/svn/trunk/
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Flip on the magic path handling #

Total comments: 3

Patch Set 3 : Switch to xcode_config_file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M pylib/gyp/generator/xcode.py View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M pylib/gyp/xcodeproj_file.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8
stuartmorgan
14 years, 9 months ago (2010-06-22 22:19:05 UTC) #1
stuartmorgan
Hm, it looks like I'm missing something; if I put a xcode_config in a configuration ...
14 years, 9 months ago (2010-06-22 22:49:24 UTC) #2
stuartmorgan
On 2010/06/22 22:49:24, stuartmorgan wrote: > Is there an incantation I need in this patch ...
14 years, 9 months ago (2010-06-22 23:00:45 UTC) #3
Mark Mentovai
Where are you planning on using this?
14 years, 9 months ago (2010-06-22 23:01:50 UTC) #4
thomasvl
lgtm, but let mark give it blessing before it lands. It's been a while since ...
14 years, 9 months ago (2010-06-23 12:20:15 UTC) #5
Mark Mentovai
LGTM, but… There is a way to set project-wide settings. The comment by the code ...
14 years, 9 months ago (2010-06-23 14:04:41 UTC) #6
Mark Mentovai
The support for project-wide settings may be inflexible enough for your needs: we currently only ...
14 years, 9 months ago (2010-06-23 14:06:40 UTC) #7
stuartmorgan
14 years, 9 months ago (2010-06-23 14:51:46 UTC) #8
On 2010/06/23 14:06:40, Mark Mentovai wrote:
> The support for project-wide settings may be inflexible enough for your needs

It is, so I didn't add it. If anyone ever needs it, we can alway revisit it
then.

http://codereview.appspot.com/1687044/diff/4001/5002
File pylib/gyp/generator/xcode.py (right):

http://codereview.appspot.com/1687044/diff/4001/5002#newcode1126
pylib/gyp/generator/xcode.py:1126: if 'xcode_config' in configuration:
On 2010/06/23 14:04:41, Mark Mentovai wrote:
> I prefer xcode_config_file.

Done; you'll want to update the language spec page, since that's where I got the
name xcode_config.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b