Issue 1681043: Dependency of 'transparent and 'whiteout

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1681043: Dependency of 'transparent and 'whiteout (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 10 months ago by marc

Modified:
13 years, 10 months ago

Reviewers:
Neil Puttock

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Dependency of 'transparent and 'whiteout If a grob is invisible, the 'whiteout property should not be taken into account. This will simplify the tablature handling and doesn't affect the rest.

Patch Set 1 #

Total comments: 2

Created: 13 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -3 lines)			Patch
	M	lily/grob.cc	View		2 chunks	+5 lines, -2 lines	2 comments	Download
	M	scm/define-grob-properties.scm	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Neil Puttock

LGTM. http://codereview.appspot.com/1681043/diff/1/2 File lily/grob.cc (right): http://codereview.appspot.com/1681043/diff/1/2#newcode126 lily/grob.cc:126: bool grob_transparent = to_boolean (get_property ("transparent")); This is ...

13 years, 10 months ago (2010-06-20 20:56:34 UTC) #1

marc

13 years, 10 months ago (2010-06-21 08:47:03 UTC) #2

n.puttock@gmail.com schrieb:
> LGTM.
>
>
> http://codereview.appspot.com/1681043/diff/1/2
> File lily/grob.cc (right):
>
> http://codereview.appspot.com/1681043/diff/1/2#newcode126
> lily/grob.cc:126: bool grob_transparent = to_boolean (get_property
> ("transparent"));
> This is a bit fussy.  `transparent' will do, since it's clear from the
> file we're working with grobs and grob-properties.
>
> http://codereview.appspot.com/1681043/diff/1/2#newcode127
> lily/grob.cc:127:
> whitespace error
>
> http://codereview.appspot.com/1681043/show
>
I just saw you corrected it and pushed, thanks!

Marc

Expand All Messages | Collapse All Messages