Issue 1674050: Added checks for webgl_ and _webgl_ reserved identifiers. This currently only...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1674050: Added checks for webgl_ and _webgl_ reserved identifiers. This currently only... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 11 months ago by Alok Priyadarshi

Modified:
13 years, 11 months ago

Reviewers:
kbr1, dgkoch

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Added checks for webgl_ and _webgl_ reserved identifiers. This currently only checks variable and function names. Struct names and field names will be added in the another CL. BUG=11

Patch Set 1 #

Created: 13 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -5 lines)			Patch
M	src/compiler/ParseHelper.h	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/compiler/ParseHelper.cpp	View	1 chunk	+14 lines, -1 line	0 comments	Download
M	src/compiler/ShHandle.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/compiler/ShaderLang.cpp	View	2 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

dgkoch

Looks good to me, other than possibly the TODO(alokp) in ShaderLang.cpp line 173. Did you ...

13 years, 11 months ago (2010-07-19 20:53:41 UTC) #2

Alok Priyadarshi

On 2010/07/19 20:53:41, dgkoch wrote: > Looks good to me, other than possibly the TODO(alokp) ...

13 years, 11 months ago (2010-07-19 20:56:31 UTC) #3

dgkoch

On 2010/07/19 20:56:31, alokp wrote: > On 2010/07/19 20:53:41, dgkoch wrote: > > Looks good ...

13 years, 11 months ago (2010-07-19 21:34:04 UTC) #4

LGTM

Expand All Messages | Collapse All Messages