Issue 167041: Create request with datetime.datetime instead of mx.Datetime for date fields

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 167041: Create request with datetime.datetime instead of mx.Datetime for date fields (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 4 months ago by bch

Modified:
14 years, 4 months ago

Reviewers:
timitos, ced1

Visibility:
Public.

Description

... because the validation in backend/fields.py:108 only allow datetime.datetime.

Patch Set 2 : Use mx.DatetTime for now and removed debug raise #

Created: 14 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	trytond/ir/cron.py	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

timitos

works for me http://codereview.appspot.com/167041/diff/1/2 File trytond/ir/cron.py (right): http://codereview.appspot.com/167041/diff/1/2#newcode148 trytond/ir/cron.py:148: raise why is this part of ...

14 years, 4 months ago (2009-12-07 11:02:01 UTC) #2

ced1

http://codereview.appspot.com/167041/diff/1/2 File trytond/ir/cron.py (right): http://codereview.appspot.com/167041/diff/1/2#newcode151 trytond/ir/cron.py:151: now = datetime.datetime.now() Should stay a DateTime http://codereview.appspot.com/167041/diff/1/2#newcode178 trytond/ir/cron.py:178: ...

14 years, 4 months ago (2009-12-07 11:10:47 UTC) #3

ced1

On 2009/12/07 12:10:28, bch wrote: > Ok. Can you check which version are affected.

14 years, 4 months ago (2009-12-07 12:11:45 UTC) #5

bch

On 2009/12/07 12:11:45, ced wrote: > On 2009/12/07 12:10:28, bch wrote: > > > > ...

14 years, 4 months ago (2009-12-07 12:41:54 UTC) #6

ced1

14 years, 4 months ago (2009-12-07 12:44:44 UTC) #7

On 2009/12/07 12:41:54, bch wrote:
> On 2009/12/07 12:11:45, ced wrote:
> > On 2009/12/07 12:10:28, bch wrote:
> > > 
> > 
> > Ok. Can you check which version are affected.
> 
> The bug appear only on trunk, the check on datetime fields was added one month
> after the release (and has not been backported).

Ok.

Expand All Messages | Collapse All Messages