staff-symbol-referencer: ledger logic; issue 4184

staff-symbol-referencer: ledger logic; issue 4184

[lemzwerg, 2014-11-02 06:43:34]

LGTM

https://codereview.appspot.com/167040043/diff/1/lily/side-position-interface.cc
File lily/side-position-interface.cc (right):

https://codereview.appspot.com/167040043/diff/1/lily/side-position-interface....
lily/side-position-interface.cc:383: /* If we are closer to the staff than the
notehad, quantize for ledger lines. */
s/notehad/notehead/

But I wonder whether this is the best description – it's rather about note heads
and attached grobs having the same direction, right?

[Keith, 2014-11-02 19:04:00]

'notehead' noted.

On Sat, 01 Nov 2014 23:43:34 -0700, <lemzwerg@googlemail.com> wrote:
/* If we are closer to the staff than the notehead,
    quantize for ledger lines. */
> But I wonder whether this is the best description – it's rather about
> note heads and attached grobs having the same direction, right?

Well, if by 'direction' of the notehead you mean its position relative to the
staff, then yes, but he code does not use the word 'direction' for that.

The comment says loosely what case we are trying to catch, and fits either old
or new code.
Matching the code would be "if the Script is above(below) the Head but
below(above) the staff, avoid ledger lines"