DSDV Routing Protocol for ns-3

DSDV(Destination Sequence Distance-Vector) is a proactive routing protocol. It is one of the earliest routing protocols and the predecessor to AODV. Route selection is based on the freshness of routes of the routes. Routes with better metric in this case, hop count are preferred. 
We have implemented this protocol for ns-3 simulator. We have used the current AODV code as reference for implementing DSDV. This work is done as a class project by the students in Resilinets group at The University of Kansas. 
Wiki: https://wiki.ittc.ku.edu/resilinets/Main_Page#ResiliNets_Wiki

[Pavel Boyko, 2010-06-16 06:17:59]

Hi, Hemanth,

Some very initial comments (actually I didn't read the code yet, sorry):

1. I'm happy to see massive copy-paste from AODV :) Did you consider an
opportunity of sharing some code between on-demand routing protocols?

2. Please move helper class from src/helper into src/routing/dsdv -- this is a
new rule designed to make future ns-3 more modular.

3. Tests! We definitely need some unit and system tests to verify your
implementation. Consider an option of reproducing aodv/test structure. Btw, does
your DSDV model works correctly with TCP? (current AODV doesn't).

4. Examples. Please include one or two simple usage examples into
src/routing/dsdv/example directory.

[Hemanth Narra, 2010-06-16 20:56:27]

On 2010/06/16 06:17:59, Pavel Boyko wrote:
> Hi, Hemanth,
> 
> Some very initial comments (actually I didn't read the code yet, sorry):
> 
> 1. I'm happy to see massive copy-paste from AODV :) Did you consider an
> opportunity of sharing some code between on-demand routing protocols?
> 
> 2. Please move helper class from src/helper into src/routing/dsdv -- this is a
> new rule designed to make future ns-3 more modular.
> 
> 3. Tests! We definitely need some unit and system tests to verify your
> implementation. Consider an option of reproducing aodv/test structure. Btw,
does
> your DSDV model works correctly with TCP? (current AODV doesn't).
> 
> 4. Examples. Please include one or two simple usage examples into
> src/routing/dsdv/example directory.

Hi Pavel,

I have used AODV to be the base model for implementing DSDV. This was actually
started as a class project and me being kind of new to programming and
relatively new to ns-3 wanted some structure to base by implementation upon.
ns-3 having only only two MANET routing protocols made my work simpler :). I
weighed my options and figured that using AODV is more suitable as it can be
said, a successor to DSDV in a sense(though AODV is on-demand and DSDV is
proactive) and also uses similar table structure as AODV. 

The code that can be shared among these protocols is the entire queue structure
using the loopback and the base class functions that should be
implemented(except for few changes to suit DSDV).

I am currently writing the test cases and will add them soon. Also will move the
helper files and examples to DSDV folder. I have not tested DSDV with TCP as all
the work we have been doing was with UDP traffic only. Could you tell me what
aspect of AODV is giving trouble with TCP?

Thanks,
Hemanth

[Tom Henderson, 2010-06-17 04:19:43]

> Could you tell me what
> aspect of AODV is giving trouble with TCP?
> 

See bug 879:
http://www.nsnam.org/bugzilla/show_bug.cgi?id=879
which I hope to get fixed in this release cycle.

[Tom Henderson, 2010-06-24 22:52:07]

Hi Hemanth, this is a good start; if you are willing to finish it off, we could
aim for merging this during the next release cycle.  We could at that time try
to follow Pavel's suggestion to factor out common classes (e.g.
src/routing/on-demand/).  

Pavel already commented on tests and examples; we'll also need doxygen for all
public classes and members, documentation about the scope of the model (dsdv.h),
and all new files should be run through the "check-style.py" utility in the
utils/ directory.  Plus some of the coding style things I pointed out in-line.

http://codereview.appspot.com/1668042/diff/1/7
File src/routing/dsdv/dsdv-routing-protocol.cc (right):

http://codereview.appspot.com/1668042/diff/1/7#newcode43
src/routing/dsdv/dsdv-routing-protocol.cc:43: #define holddownTime  (Scalar
(Holdtimes) * PeriodicUpdateInterval)
suggest you make this a function instead of a macro

http://codereview.appspot.com/1668042/diff/1/7#newcode101
src/routing/dsdv/dsdv-routing-protocol.cc:101: MaxQueueLen (250),
these member initializers are immediately overridden by the attribute default
value configuration (which happens after the object is constructed).  So, e.g.
MaxQueueLen (250) is effectively a no-op and can be deleted.

See also the coding style about naming (should be m_maxQueueLen)

http://codereview.appspot.com/1668042/diff/1/7#newcode123
src/routing/dsdv/dsdv-routing-protocol.cc:123: MakeTimeChecker ())
Good use of attribute system.  Note that you can exploit the Checker() methods
to enforce valid ranges of these parameters, if you care to do so.

http://codereview.appspot.com/1668042/diff/1/7#newcode202
src/routing/dsdv/dsdv-routing-protocol.cc:202: {
For merged code we would like to see use of the NS_LOG_FUNCTION () macros.  This
allows users to easily trace function flow.

http://codereview.appspot.com/1668042/diff/1/8
File src/routing/dsdv/dsdv-routing-protocol.h (right):

http://codereview.appspot.com/1668042/diff/1/8#newcode75
src/routing/dsdv/dsdv-routing-protocol.h:75: {
In ns-3, we avoid putting function definitions in the header files, except for
inlined functions.

http://codereview.appspot.com/1668042/diff/1/13
File src/routing/dsdv/dsdv.h (right):

http://codereview.appspot.com/1668042/diff/1/13#newcode33
src/routing/dsdv/dsdv.h:33: *  selection.
This file could be expanded; see aodv.h for an example.  What we would like to
see in the doxygen is some clearer definition of what is modeled and what is out
of scope of this model, and any caveats or issues that you may want to alert
users to.

http://codereview.appspot.com/1668042/diff/1/14
File src/routing/dsdv/dsdv.txt (right):

http://codereview.appspot.com/1668042/diff/1/14#newcode3
src/routing/dsdv/dsdv.txt:3: Wiki:
https://wiki.ittc.ku.edu/resilinets/Main_Page#ResiliNets_Wiki
This file could be deleted; this info already in dsdv.h

[Luiz Felipe Saggioro, 2010-07-13 17:44:30]

On 2010/06/26 02:00:25, hemanthnarra222 wrote:
> 

Is it possible for me to include this codes in ns-3? I didnt find de Helper
class on the file list above. In case its possible, can you give me some hints?

Thanks

[Tom Henderson, 2010-08-22 22:23:55]

On 2010/06/26 02:00:25, Hemanth Narra wrote:
> 

Hemanth, can you let us know about your future plans and availability to work on
the issues that Pavel raised?  (need examples and tests, need to consider
whether to refactor to reuse AODV code, need to test with TCP)? 

For TCP, the issue with AODV has been fixed as of ns-3.9.  I can help you with a
similar solution for DSDV if you would like.

[Hemanth Narra, 2010-08-27 03:16:47]

Hi Tom,

My Apologies for the late reply. I was in the middle of some work. I have
uploaded a new patchset with the new model and with a testcase and example.
Also, I have made changes to the code for that TCP issue with the same fix you
made for aodv. 

Please let me know if you need anything else.

Thanks,
Hemanth.
http://codereview.appspot.com/1668042/

[Guilherme Rodrigues, 2010-09-09 03:32:32]

Hi,
how are you??

Well, I'm with a little problem. I cann't compile the files about the DSDV. I
distribute all the files in their respective directories, but when I run the
command "./waf" the following error appears.

/home/guilherme/Desktop/ns-allinone-3.9/ns-3.9/src/routing/dsdv/wscript: error:
Traceback (most recent call last):
  File
"/home/guilherme/Desktop/ns-allinone-3.9/ns-3.9/.waf-1.5.16-e6d03192b5ddfa5ef2c8d65308e48e42/wafadmin/Utils.py",
line 197, in load_module
    exec(compile(code,file_path,'exec'),module.__dict__)
  File
"/home/guilherme/Desktop/ns-allinone-3.9/ns-3.9/src/routing/dsdv/wscript", line
23
    bld.add_subdirs('examples')
      ^
IndentationError: expected an indented block

I took all the files exactly as they are on site., and I don't know how to fix
it. Can you give some help??

thanks,
Guilherme Rodrigues

[Hemanth Narra, 2010-09-09 05:56:42]

Hi Guilherme,

I have run this on ns3.9 and it worked for me now. I was not able to replicate
your issue. Did you create all the directories as specified in the dsdv
directory? The directories that should be present are 'model', examples',
'helper', 'test' and 'doc'. 

Also apply the files in patchset 3 only and forget about the above two. 

Thanks,
Hemanth.

On 2010/09/09 03:32:32, Guilherme Rodrigues wrote:
> Hi,
> how are you??
> 
> Well, I'm with a little problem. I cann't compile the files about the DSDV. I
> distribute all the files in their respective directories, but when I run the
> command "./waf" the following error appears.
> 
> /home/guilherme/Desktop/ns-allinone-3.9/ns-3.9/src/routing/dsdv/wscript:
error:
> Traceback (most recent call last):
>   File
>
"/home/guilherme/Desktop/ns-allinone-3.9/ns-3.9/.waf-1.5.16-e6d03192b5ddfa5ef2c8d65308e48e42/wafadmin/Utils.py",
> line 197, in load_module
>     exec(compile(code,file_path,'exec'),module.__dict__)
>   File
> "/home/guilherme/Desktop/ns-allinone-3.9/ns-3.9/src/routing/dsdv/wscript",
line
> 23
>     bld.add_subdirs('examples')
>       ^
> IndentationError: expected an indented block
> 
> I took all the files exactly as they are on site., and I don't know how to fix
> it. Can you give some help??
> 
> thanks,
> Guilherme Rodrigues

[harriknight7, 2010-12-15 07:47:16]

hello 

i am working on dsdv in ns-3.7 someone help me to add dsdv in ns-3.7.kindly help
me how to add dsdv in ns-3.


thanks

[Guilherme Rodrigues, 2010-12-15 10:54:16]

Hi,

I also had this doubt some time ago, but I did it and it works for me.


"
Hi,
    I also ran the patch 3 of ns3 3.9.you need not create a separate folder
for dsdv .All you have to do is go to the ns-3.9 directory copy the patch
there and in the terminal go to ns-3.9 directory and there type the command
$ patch -p1 < patchfilename. It works for me check it.

Regards,
Meena
"



2010/12/15 <harriknight7@gmail.com>

> hello
>
> i am working on dsdv in ns-3.7 someone help me to add dsdv in
> ns-3.7.kindly help me how to add dsdv in ns-3.
>
>
> thanks
>
> http://codereview.appspot.com/1668042/
>



-- 
Guilherme Rodrigues
Estudante Ciência da Computação
Gerente de Redes BCC
Universidade Federal de Alfenas / MG

[harriknight7, 2010-12-15 11:05:18]

Meena i have installed ns-3.7.which files inlcude in that folder..?









On 2010/12/15 10:54:16, Guilherme Rodrigues wrote:
> Hi,
> 
> I also had this doubt some time ago, but I did it and it works for me.
> 
> 
> "
> Hi,
>     I also ran the patch 3 of ns3 3.9.you need not create a separate folder
> for dsdv .All you have to do is go to the ns-3.9 directory copy the patch
> there and in the terminal go to ns-3.9 directory and there type the command
> $ patch -p1 < patchfilename. It works for me check it.
> 
> Regards,
> Meena
> "
> 
> 
> 
> 2010/12/15 <mailto:harriknight7@gmail.com>
> 
> > hello
> >
> > i am working on dsdv in ns-3.7 someone help me to add dsdv in
> > ns-3.7.kindly help me how to add dsdv in ns-3.
> >
> >
> > thanks
> >
> > http://codereview.appspot.com/1668042/
> >
> 
> 
> 
> -- 
> Guilherme Rodrigues
> Estudante Ciência da Computação
> Gerente de Redes BCC
> Universidade Federal de Alfenas / MG

[Hemanth Narra, 2010-12-15 20:15:05]

On 2010/12/15 20:09:34, Hemanth Narra wrote:
Patchset 5 is created to incorporate changes made to print the routing table
feature along with some cosmetic changes to the code. Please use this code only
after applying the patch that supports the print routing table feature from
http://codereview.appspot.com/3613041/ . To run the code with current version of
ns-3, use the patchset 3 and 4.

[harriknight7, 2010-12-16 08:58:50]

hello every one, i want to run dsdv in ns-3, and make a dsv folder and create a
filess that desribe above, but when i run ./waf i got this erorr, can onyone
tell me how i remove this
 /home/haris/haris/ns-allinone-3.7/ns-3.7/src/routing/dsdv/wscript: error:
Traceback (most recent call last):
  File
"/home/haris/haris/ns-allinone-3.7/ns-3.7/.waf-1.5.9-d1e0349fc8937631a656fb8ea7e99063/wafadmin/Utils.py",
line 180, in load_module
    exec(code,module.__dict__)
  File "<string>", line 1
    +## -*- Mode: python; py-indent-offset: 4; indent-tabs-mode: nil; coding:
utf-8; -*-
                                                                                
      
^
SyntaxError: invalid syntax

[harriknight7, 2010-12-19 10:33:26]

hello every one, i want to knw how to run dsdv and olsr in ns-3,
because when i run both of these protocols i got follwing errors,
kindly tell me how i remove this thanx.
....
.
.
.
program 'dsdv-routing-protocol' not found; available programs are:
['emu-sock-creator', '../../../devices/emu/emu-sock-creator', 'tap-
creator', '../../../devices/tap-bridge/tap-creator', 'wifi-phy-test',
'../../../devices/wifi/wifi-phy-test', 'main-attribute-value',
'../../../../samples/main-attribute-value', 'main-callback',
'../../../../samples/main-callback', 'main-simulator', '../../../../
samples/main-simulator', 'main-ptr', '../../../../samples/main-ptr',
'main-random-variable', '../../../../samples/main-random-variable',
'main-packet-header', '../../../../samples/main-packet-header', 'main-
packet-tag', '../../../../samples/main-packet-tag', 'main-test-sync',
'../../../../samples/main-test-sync', 'main-simple', '../../../../
samples/main-simple', 'main-grid-topology', '../../../../samples/main-
grid-topology', 'main-random-topology', '../../../../samples/main-
random-topology', 'main-random-walk', '../../../../samples/main-random-
walk', 'main-propagation-loss', '../../../../samples/main-propagation-
loss', 'main-ns2-mob', '../../../../samples/main-ns2-mob', 'sample-
random-variable', '../../../../samples/sample-random-variable', 'test-
runner', '../../../../utils/test-runner', 'bench-simulator',
'../../../../utils/bench-simulator', 'bench-packets', '../../../../
utils/bench-packets', 'print-introspected-doxygen', '../../../../utils/
print-introspected-doxygen', 'dumbbell-animation', '../../../../
examples/animation/dumbbell-animation', 'grid-animation', '../../../../
examples/animation/grid-animation', 'star-animation', '../../../../
examples/animation/star-animation', 'simple-error-model', '../../../../
examples/error-model/simple-error-model', 'mesh', '../../../../
examples/mesh/mesh', 'udp-echo', '../../../../examples/udp/udp-echo',
'socket-bound-static-routing', '../../../../examples/socket/socket-
bound-static-routing', 'socket-bound-tcp-static-routing', '../../../../
examples/socket/socket-bound-tcp-static-routing', 'emu-udp-echo',
'../../../../examples/emulation/emu-udp-echo', 'emu-ping',
'../../../../examples/emulation/emu-ping', 'object-names',
'../../../../examples/naming/object-names', 'hello-simulator',
'../../../../examples/tutorial/hello-simulator', 'first', '../../../../
examples/tutorial/first', 'second', '../../../../examples/tutorial/
second', 'third', '../../../../examples/tutorial/third', 'fourth',
'../../../../examples/tutorial/fourth', 'fifth', '../../../../examples/
tutorial/fifth', 'csma-one-subnet', '../../../../examples/csma/csma-
one-subnet', 'csma-bridge', '../../../../examples/csma/csma-bridge',
'csma-bridge-one-hop', '../../../../examples/csma/csma-bridge-one-
hop', 'csma-broadcast', '../../../../examples/csma/csma-broadcast',
'csma-packet-socket', '../../../../examples/csma/csma-packet-socket',
'csma-multicast', '../../../../examples/csma/csma-multicast', 'csma-
star', '../../../../examples/csma/csma-star', 'csma-raw-ip-socket',
'../../../../examples/csma/csma-raw-ip-socket', 'csma-ping',
'../../../../examples/csma/csma-ping', 'tcp-large-transfer',
'../../../../examples/tcp/tcp-large-transfer', 'tcp-nsc-lfn',
'../../../../examples/tcp/tcp-nsc-lfn', 'tcp-nsc-zoo', '../../../../
examples/tcp/tcp-nsc-zoo', 'tcp-star-server', '../../../../examples/
tcp/tcp-star-server', 'star', '../../../../examples/tcp/star',
'virtual-net-device', '../../../../examples/tunneling/virtual-net-
device', 'realtime-udp-echo', '../../../../examples/realtime/realtime-
udp-echo', 'tap-csma', '../../../../examples/tap/tap-csma', 'tap-wifi-
dumbbell', '../../../../examples/tap/tap-wifi-dumbbell', 'mixed-
wireless', '../../../../examples/wireless/mixed-wireless', 'wifi-
adhoc', '../../../../examples/wireless/wifi-adhoc', 'wifi-clear-
channel-cmu', '../../../../examples/wireless/wifi-clear-channel-cmu',
'wifi-ap', '../../../../examples/wireless/wifi-ap', 'wifi-wired-
bridging', '../../../../examples/wireless/wifi-wired-bridging',
'simple-wifi-frame-aggregation', '../../../../examples/wireless/simple-
wifi-frame-aggregation', 'multirate', '../../../../examples/wireless/
multirate', 'wifi-simple-adhoc', '../../../../examples/wireless/wifi-
simple-adhoc', 'wifi-simple-adhoc-grid', '../../../../examples/
wireless/wifi-simple-adhoc-grid', 'wifi-simple-infra', '../../../../
examples/wireless/wifi-simple-infra', 'wifi-simple-interference',
'../../../../examples/wireless/wifi-simple-interference', 'udp-client-
server', '../../../../examples/udp-client-server/udp-client-server',
'udp-trace-client-server', '../../../../examples/udp-client-server/udp-
trace-client-server', 'dynamic-global-routing', '../../../../examples/
routing/dynamic-global-routing', 'static-routing-slash32',
'../../../../examples/routing/static-routing-slash32', 'global-routing-
slash32', '../../../../examples/routing/global-routing-slash32',
'global-injection-slash32', '../../../../examples/routing/global-
injection-slash32', 'simple-global-routing', '../../../../examples/
routing/simple-global-routing', 'simple-alternate-routing',
'../../../../examples/routing/simple-alternate-routing', 'mixed-global-
routing', '../../../../examples/routing/mixed-global-routing', 'simple-
point-to-point-olsr', '../../../../examples/routing/simple-point-to-
point-olsr', 'nix-simple', '../../../../examples/routing/nix-simple',
'nms-p2p-nix', '../../../../examples/routing/nms-p2p-nix', 'simple-
routing-ping6', '../../../../examples/routing/simple-routing-ping6',
'aodv', '../../../../examples/routing/aodv', 'wifi-example-sim',
'../../../../examples/stats/wifi-example-sim', 'icmpv6-redirect',
'../../../../examples/ipv6/icmpv6-redirect', 'ping6', '../../../../
examples/ipv6/ping6', 'radvd', '../../../../examples/ipv6/radvd',
'radvd-two-prefix', '../../../../examples/ipv6/radvd-two-prefix',
'test-ipv6', '../../../../examples/ipv6/test-ipv6', 'fragmentation-
ipv6', '../../../../examples/ipv6/fragmentation-ipv6', 'loose-routing-
ipv6', '../../../../examples/ipv6/loose-routing-ipv6', 'myfirst',
'../../../../scratch/myfirst', 'simple', '../../../../scratch/simple',
'multiple-sources', '../../../../scratch/multiple-sources/multiple-
sources']