Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4791)

Issue 1665053: Fix #1192. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 9 months ago by Neil Puttock
Modified:
13 years, 8 months ago
Reviewers:
joeneeman
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Fix #1192. System separator positioning depends on correct calculation of the paper-system property 'staff-refpoint-extent, but this is incorrect for systems which include Staff-like contexts since the Vertically_spaced_contexts_engraver fails to acknowledge axis-groups whose origin context is aliased to Staff. Though it's simple to enhance the axis-group acknowledger to detect aliased contexts, a better solution is to remove the Vertically_spaced_context_engraver: spaceability is now determined by 'staff-affinity, so the engraver's more limited functionality can be folded into System::get_paper_system (). * lily/system.cc (get_paper_system): calculate 'staff-refpoint-extent via VerticalAlignment and Page_layout_problem::is_spaceable () remove 'spaceable-staves * lily/vertically-spaced-context-engraver.cc: delete * ly/engraver-init.ly: remove Vertically_spaced_context_engraver and verticallySpacedContexts * scm/define-context-properties.scm (all-user-translation-properties): remove verticallySpacedContexts definition * scm/define-grob-interfaces.scm: remove vertically-spaceable-interface * scm/define-grob-properties.scm (all-internal-grob-properties): remove 'spaceable-staves definition * scm/define-grobs.scm (all-grob-descriptions): remove vertically-spaceable-interface from VerticalAxisGroup

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -104 lines) Patch
M lily/system.cc View 4 chunks +12 lines, -8 lines 0 comments Download
D lily/vertically-spaced-context-engraver.cc View 1 chunk +0 lines, -81 lines 0 comments Download
M ly/engraver-init.ly View 2 chunks +0 lines, -2 lines 0 comments Download
M scm/define-context-properties.scm View 1 chunk +0 lines, -3 lines 0 comments Download
M scm/define-grob-interfaces.scm View 1 chunk +0 lines, -6 lines 0 comments Download
M scm/define-grob-properties.scm View 1 chunk +0 lines, -2 lines 0 comments Download
M scm/define-grobs.scm View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 1
joeneeman
13 years, 9 months ago (2010-07-22 22:27:26 UTC) #1
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b