Hi Alok, My main question about these changes are: what is the motivation? It is ...
14 years, 4 months ago
(2010-07-19 21:32:32 UTC)
#2
Hi Alok,
My main question about these changes are: what is the motivation? It is simply
to clean up unused code, or is this getting in the way for implementing
additional functionality?
I'm not sure I like the idea of deleting the linker, unnecessarily. While we
may not be using it currently, I could see potential use cases for it in the
future and would rather not just throw it away.
Daniel
My motivation was simply to delete unused code and make the translator API less confusing ...
14 years, 4 months ago
(2010-07-20 18:49:21 UTC)
#3
My motivation was simply to delete unused code and make the translator API less
confusing for the third-party developers.
I did not know you have plans for using the linker. I can leave it there in that
case. But if you are not sure I would rather delete it for now and bring it back
later as needed - it will always be there in the svn. The translator API may
evolve as we add more functionality (webgl, etc) or address security issues. The
linker API may get left behind and you will have to redo it in the future
anyway.
On 2010/07/20 18:49:21, alokp wrote: > My motivation was simply to delete unused code and ...
14 years, 4 months ago
(2010-07-20 18:59:41 UTC)
#4
On 2010/07/20 18:49:21, alokp wrote:
> My motivation was simply to delete unused code and make the translator API
less
> confusing for the third-party developers.
>
> I did not know you have plans for using the linker. I can leave it there in
that
> case. But if you are not sure I would rather delete it for now and bring it
back
> later as needed - it will always be there in the svn. The translator API may
> evolve as we add more functionality (webgl, etc) or address security issues.
The
> linker API may get left behind and you will have to redo it in the future
> anyway.
I think that if this code is likely to be used in the future that it should be
left in place; it is easy to forget about code which has been deleted. However I
don't feel strongly about this, so I'd like to defer this review and discussion
to you and Daniel.
On 2010/07/20 18:59:41, kbr1 wrote: > On 2010/07/20 18:49:21, alokp wrote: > > My motivation ...
14 years, 4 months ago
(2010-07-21 03:11:51 UTC)
#5
On 2010/07/20 18:59:41, kbr1 wrote:
> On 2010/07/20 18:49:21, alokp wrote:
> > My motivation was simply to delete unused code and make the translator API
> less
> > confusing for the third-party developers.
> >
> > I did not know you have plans for using the linker. I can leave it there in
> that
> > case. But if you are not sure I would rather delete it for now and bring it
> back
> > later as needed - it will always be there in the svn. The translator API may
> > evolve as we add more functionality (webgl, etc) or address security issues.
> The
> > linker API may get left behind and you will have to redo it in the future
> > anyway.
>
> I think that if this code is likely to be used in the future that it should be
> left in place; it is easy to forget about code which has been deleted. However
I
> don't feel strongly about this, so I'd like to defer this review and
discussion
> to you and Daniel.
There is a possibility that we may do a d3d9-bytecode backend instead of HLSL
backend at some point in the future.
However, I talked it over with our compiler engineer and he doesn't think the
linker interface as it exists is really very useful.
If needed we would likely be better of with a completely custom implementation
and matching interface if there is a need to do this.
So feel free to go ahead and remove this.
Daniel
Issue 1665050: Cleaned up translator API. Deleted unsupported dead code.
(Closed)
Created 14 years, 4 months ago by Alok Priyadarshi
Modified 14 years, 4 months ago
Reviewers: kbr1, dgkoch
Base URL: http://angleproject.googlecode.com/svn/trunk/
Comments: 0