Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2564)

Issue 1665050: Cleaned up translator API. Deleted unsupported dead code. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 4 months ago by Alok Priyadarshi
Modified:
14 years, 4 months ago
Reviewers:
kbr1, dgkoch
CC:
angleproject-review_googlegroups.com
Base URL:
http://angleproject.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Cleaned up translator API. Deleted unsupported dead code. BUG=9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -477 lines) Patch
M include/GLSLANG/ShaderLang.h View 5 chunks +7 lines, -80 lines 0 comments Download
M samples/translator/translator.cpp View 3 chunks +2 lines, -5 lines 0 comments Download
M src/build_angle.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/Common.h View 1 chunk +1 line, -1 line 0 comments Download
D src/compiler/Link.cpp View 1 chunk +0 lines, -62 lines 0 comments Download
M src/compiler/ShHandle.h View 4 chunks +2 lines, -74 lines 0 comments Download
M src/compiler/ShaderLang.cpp View 9 chunks +8 lines, -246 lines 0 comments Download
M src/compiler/translator_common.vcproj View 5 chunks +4 lines, -8 lines 0 comments Download

Messages

Total messages: 6
Alok Priyadarshi
14 years, 4 months ago (2010-07-16 21:35:28 UTC) #1
dgkoch
Hi Alok, My main question about these changes are: what is the motivation? It is ...
14 years, 4 months ago (2010-07-19 21:32:32 UTC) #2
Alok Priyadarshi
My motivation was simply to delete unused code and make the translator API less confusing ...
14 years, 4 months ago (2010-07-20 18:49:21 UTC) #3
kbr1
On 2010/07/20 18:49:21, alokp wrote: > My motivation was simply to delete unused code and ...
14 years, 4 months ago (2010-07-20 18:59:41 UTC) #4
dgkoch
On 2010/07/20 18:59:41, kbr1 wrote: > On 2010/07/20 18:49:21, alokp wrote: > > My motivation ...
14 years, 4 months ago (2010-07-21 03:11:51 UTC) #5
Alok Priyadarshi
14 years, 4 months ago (2010-07-21 18:52:12 UTC) #6
Thanks Daniel.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b