Issue 166046: Make rpc.js window.frames code more robust

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 166046: Make rpc.js window.frames code more robust (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 9 months ago by johnfargo

Modified:
15 years, 8 months ago

Reviewers:
Paul Lindner, shindig.remailer

Base URL:
http://svn.apache.org/repos/asf/incubator/shindig/trunk/

Visibility:
Public.

Description

Turns out IE8 treats this as an Array access rather than Object/Map: window.frames["1234"] This caused gadgets.rpc to break when the frame name consists only of isDigit characters. I propose this patch as a way of centralizing the targetWindow retrieval mechanism for rpc. It also tries falling back to document.getElementById(...) if a window.frames find doesn't work. Comments welcome.

Patch Set 1 #

Patch Set 2 : Old patch accidentally uploaded. Fixed (correctly this time). #

Total comments: 1

Patch Set 3 : @Paul, sgtm. Style update. #

Created: 15 years, 9 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -9 lines)			Patch
features/src/main/javascript/features/rpc/rmr.transport.js	View	1 2	1 chunk	+3 lines, -2 lines	0 comments	Download
features/src/main/javascript/features/rpc/rpc.js	View	1 2	3 chunks	+28 lines, -6 lines	0 comments	Download
features/src/main/javascript/features/rpc/wpm.transport.js	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

johnfargo

Old patch accidentally uploaded. Fixed (correctly this time).

15 years, 9 months ago (2009-12-03 23:04:51 UTC) #3

Paul Lindner

lgtm other than the style issue. http://codereview.appspot.com/166046/diff/7/1007 File features/src/main/javascript/features/rpc/rpc.js (left): http://codereview.appspot.com/166046/diff/7/1007#oldcode297 features/src/main/javascript/features/rpc/rpc.js:297: Since this is ...

15 years, 9 months ago (2009-12-03 23:55:07 UTC) #4

Paul Lindner

15 years, 9 months ago (2009-12-04 00:39:15 UTC) #6

On 2009/12/04 00:36:09, johnfargo wrote:
> @Paul, sgtm. Style update.

great, ship it!

Expand All Messages | Collapse All Messages