Issue 165095: Fixed super-class extension wildcards

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 165095: Fixed super-class extension wildcards (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 6 months ago by Aragos

Modified:
16 years, 5 months ago

Reviewers:
t.broyer

CC:
google-gin_googlegroups.com

Base URL:
http://google-gin.googlecode.com/svn/trunk/

Visibility:
Public.

Description

A<? super B> was incorrectly treated as A<? extends B> by Gin. Added test and fix.

Patch Set 1 #

Created: 16 years, 6 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+22 lines, -1 line)			Patch
src/com/google/gwt/inject/rebind/util/KeyUtil.java	View	1 chunk	+1 line, -1 line	0 comments	Download
test/com/google/gwt/inject/client/generics/GenericsGinModule.java	View	2 chunks	+12 lines, -0 lines	0 comments	Download
test/com/google/gwt/inject/client/generics/GenericsGinjector.java	View	1 chunk	+2 lines, -0 lines	0 comments	Download
test/com/google/gwt/inject/client/generics/GenericsTest.java	View	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

t.broyer

This one's so straightforward that LGTM. Note however that I cannot currently apply the patch ...

16 years, 5 months ago (2009-12-21 22:35:44 UTC) #1

Aragos

16 years, 5 months ago (2009-12-21 22:59:41 UTC) #2

On 2009/12/21 22:35:44, t.broyer wrote:
> This one's so straightforward that LGTM.
> 
> Note however that I cannot currently apply the patch to see if the tests
> actually pass, but the fix *looks* OK (by just reading the diffs).

Thanks for the review! I ran the tests locally against gwt 2.0 (no other changes
in the client) and they all passed, so I'll commit the change.

Expand All Messages | Collapse All Messages