Issue 165047: Implement no-canonical-prefixes

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 165047: Implement no-canonical-prefixes (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years ago by espindola

Modified:
12 years, 7 months ago

Reviewers:
chandlerc

Visibility:
Public.

Patch Set 1 #

Total comments: 3

Patch Set 2 : Implement no-canonical-prefixes #

Created: 16 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -3 lines)			Patch
M	include/clang/Driver/Options.td	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	lib/Driver/Tools.cpp	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	tools/driver/driver.cpp	View	1	3 chunks	+14 lines, -3 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

chandlerc

16 years ago (2009-12-04 03:24:49 UTC) #1

http://codereview.appspot.com/165047/diff/1/4
File tools/driver/driver.cpp (right):

http://codereview.appspot.com/165047/diff/1/4#newcode66
tools/driver/driver.cpp:66: if (!CanonicalPrefixes)
Move this before the comment, it applies to the pointer manipulation below.

http://codereview.appspot.com/165047/diff/1/4#newcode69
tools/driver/driver.cpp:69: return llvm::sys::Path::GetMainExecutable(Argv0, P);
By avoiding this, you're turning off more than symlink resolution, but that
seems reasonable given the motivation for the CL. Maybe just document that it
also turns off all of the executable-identifying code as well (eg:
/proc/self/exe, or the various Darwin queries)?

http://codereview.appspot.com/165047/diff/1/4#newcode198
tools/driver/driver.cpp:198: CanonicalPrefixes = false;
Want to break here maybe?

Expand All Messages | Collapse All Messages