Export quota information on textstats.

[provos, 2009-12-04 16:14:45]

http://codereview.appspot.com/165046/diff/14/1017
File libproxy/status.c (right):

http://codereview.appspot.com/165046/diff/14/1017#newcode375
libproxy/status.c:375: counts[1] > get_max_requests_per_hour() ? 1 : 0);
this seems like the wrong way to go about it; why can't we get a function that
determines if the proxy is over-quota and use that in all the places that need
it?

[nav, 2009-12-04 16:54:30]

http://codereview.appspot.com/165046/diff/14/1017
File libproxy/status.c (right):

http://codereview.appspot.com/165046/diff/14/1017#newcode375
libproxy/status.c:375: counts[1] > get_max_requests_per_hour() ? 1 : 0);
On 2009/12/04 16:14:45, provos wrote:
> this seems like the wrong way to go about it; why can't we get a function that
> determines if the proxy is over-quota and use that in all the places that need
> it?
I've added an is_over_quota function to proxy.c, but now I'm not able to export
the actual quota value.

I think it would be nice to have exported. how do you feel about a getter?

[provos, 2009-12-04 17:20:26]

On Fri, Dec 4, 2009 at 8:54 AM,  <nav@gmail.com> wrote:
> I think it would be nice to have exported. how do you feel about a
> getter?

That's fine.   I just think the logic for determining if something is
over quota should be in one place.

Niels.

[nav, 2009-12-04 17:28:03]

OK, I've added get_max_requests_per_hour(), and I'm exporting it on _textstats.

I'm not sure if I'm following existing style or not. I've limited my
lines to 80 chars, but it doesn't look like that is part of the style.

On Fri, Dec 4, 2009 at 12:20 PM, Niels Provos <provos@gmail.com> wrote:
> On Fri, Dec 4, 2009 at 8:54 AM,  <nav@gmail.com> wrote:
>> I think it would be nice to have exported. how do you feel about a
>> getter?
>
> That's fine.   I just think the logic for determining if something is
> over quota should be in one place.
>
> Niels.
>

[provos, 2009-12-04 17:54:57]

When I meant a central function for determining if you are over quota, I also
meant changing the code around:

          if (counts[1] >= max_requests_per_hour) {
            event_counter_add(stats_ctr_over_quota(), 1);
            inform_error(request, HTTP_SERVUNAVAIL, "Over quota.", 1);
            return;

[nav, 2009-12-04 18:10:23]

Sorry, I knew what you meant, but I forgot to change that part of the code.

Done.

On Fri, Dec 4, 2009 at 12:54 PM,  <provos@gmail.com> wrote:
> When I meant a central function for determining if you are over quota, I
> also meant changing the code around:
>
>          if (counts[1] >= max_requests_per_hour) {
>            event_counter_add(stats_ctr_over_quota(), 1);
>            inform_error(request, HTTP_SERVUNAVAIL, "Over quota.", 1);
>            return;
>
>
> http://codereview.appspot.com/165046
>

[nav, 2009-12-07 15:48:34]

Patch set 5 includes this change. 

On 2009/12/04 18:10:23, nav wrote:
> Sorry, I knew what you meant, but I forgot to change that part of the code.
> 
> Done.
> 
> On Fri, Dec 4, 2009 at 12:54 PM,  <mailto:provos@gmail.com> wrote:
> > When I meant a central function for determining if you are over quota, I
> > also meant changing the code around:
> >
> > &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;if (counts[1] >= max_requests_per_hour) {
> > &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp;event_counter_add(stats_ctr_over_quota(), 1);
> > &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;inform_error(request,
HTTP_SERVUNAVAIL, "Over quota.", 1);
> > &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;return;
> >
> >
> > http://codereview.appspot.com/165046
> >
>

[provos, 2009-12-07 15:52:18]

I thought I LGTMed on Friday already.

On Mon, Dec 7, 2009 at 7:48 AM,  <nav@gmail.com> wrote:
> Patch set 5 includes this change.
>
> On 2009/12/04 18:10:23, nav wrote:
>>
>> Sorry, I knew what you meant, but I forgot to change that part of the
>
> code.
>
>> Done.
>
>> On Fri, Dec 4, 2009 at 12:54 PM,  <mailto:provos@gmail.com> wrote:
>> > When I meant a central function for determining if you are over
>
> quota, I
>>
>> > also meant changing the code around:
>> >
>> > &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;if (counts[1] >=
>
> max_requests_per_hour) {
>>
>> > &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
>
> &nbsp;event_counter_add(stats_ctr_over_quota(), 1);
>>
>> > &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;inform_error(request,
>
> HTTP_SERVUNAVAIL, "Over quota.", 1);
>>
>> > &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;return;
>> >
>> >
>> > http://codereview.appspot.com/165046
>> >
>
>
>
>
> http://codereview.appspot.com/165046
>