Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(794)

Issue 164058: "Fix" for bottom panel not appearing in FF3 and IE6 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 2 months ago by anog
Modified:
16 years, 2 months ago
Reviewers:
Tom
CC:
googletransitdatafeed_googlegroups.com
Base URL:
http://googletransitdatafeed.googlecode.com/svn/trunk/
Visibility:
Public.

Description

This is a fix for http://code.google.com/p/googletransitdatafeed/issues/detail?id=45 It was the simplest fix I could think of, though it is probably not the best - the height is fixed instead of being dynamic and using only the required space. The fixed value was chosen with 800x600 resolutions in mind. At this resolution the text above the graph occupies four lines instead of two, and that has to be accounted for. This leaves a blank space below the graph at bigger resolutions, and bigger font sizes are not properly supported (because the height is fixed). That said, and given the purpose of this tool, I do think that having this fix is better than leaving the schedule viewer as it is. If someone more knowledgeable of web development knows how to fix it properly or if there's time in the future then this can be revisited then.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
python/gtfsscheduleviewer/files/index.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2
anog
16 years, 2 months ago (2009-12-01 15:58:32 UTC) #1
Tom
16 years, 2 months ago (2009-12-01 16:10:04 UTC) #2
Looks good.
Maybe we should make the div collapsible but that can wait for another day.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b