Issue 163048: 787 -- Eliminate segfaults due to empty list and unitialized properties

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 163048: 787 -- Eliminate segfaults due to empty list and unitialized properties (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 4 months ago by Carl

Modified:
14 years, 4 months ago

Reviewers:
Neil Puttock

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

787 -- Eliminate segfaults due to empty list and unitialized properties

Patch Set 1 #

Total comments: 6

Created: 14 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -8 lines)			Patch
	M	lily/script-column.cc	View		2 chunks	+15 lines, -8 lines	6 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

Neil Puttock

14 years, 4 months ago (2009-12-02 21:48:55 UTC) #1

LGTM.

http://codereview.appspot.com/163048/diff/1/2
File lily/script-column.cc (left):

http://codereview.appspot.com/163048/diff/1/2#oldcode161
lily/script-column.cc:161: g->set_property ("outside-staff-priority",
indent
(+ following lines)

http://codereview.appspot.com/163048/diff/1/2#oldcode168
lily/script-column.cc:168: g->set_property (
indent
(+ following lines)

http://codereview.appspot.com/163048/diff/1/2
File lily/script-column.cc (right):

http://codereview.appspot.com/163048/diff/1/2#newcode148
lily/script-column.cc:148: first =  unsmob_grob (scm_car (ss));
indent
extra space after =

http://codereview.appspot.com/163048/diff/1/2#newcode149
lily/script-column.cc:149: default_outside_staff =
first->get_property("outside-staff-priority");
indent

get_property (

http://codereview.appspot.com/163048/diff/1/2#newcode169
lily/script-column.cc:169: robust_scm2double (last_outside_staff, 0) + 0.1));
scm_to_double (last_outside_staff) (it must be a number since it's inside the
`if' block)

http://codereview.appspot.com/163048/diff/1/2#newcode177
lily/script-column.cc:177: scm_from_double (robust_scm2double
(last_outside_staff, 0) +
scm_to_double (last_outside_staff)

Expand All Messages | Collapse All Messages