Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(667)

Issue 163047: python2.4 compatibility (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 2 months ago by Tom
Modified:
16 years, 2 months ago
Reviewers:
anog
CC:
googletransitdatafeed_googlegroups.com
Base URL:
http://googletransitdatafeed.googlecode.com/svn/trunk/python/
Visibility:
Public.

Description

Get all tests passing with python 2.4: + add Jason's pure python defaultdict + fix usage in testkmlparser.py, similar to r1212 Tested by running nosetests-2.4 which I installed with sudo easy_install-2.4 nose

Patch Set 1 : Get all tests passing with python 2.4 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -3 lines) Patch
M feedvalidator.py View 1 chunk +1 line, -1 line 0 comments Download
M test/testkmlparser.py View 1 chunk +1 line, -1 line 0 comments Download
M transitfeed/_transitfeed.py View 1 chunk +1 line, -1 line 0 comments Download
M transitfeed/util.py View 1 chunk +61 lines, -0 lines 0 comments Download

Messages

Total messages: 4
Tom
I'd like to keep the tools running in python2.4 because it is the only version ...
16 years, 2 months ago (2009-11-30 22:56:57 UTC) #1
Tom
I updated this with raw email removed and using same indentation as the rest of ...
16 years, 2 months ago (2009-12-01 19:14:14 UTC) #2
anog
Looks good to me.
16 years, 2 months ago (2009-12-02 21:56:41 UTC) #3
Tom
16 years, 2 months ago (2009-12-03 15:31:21 UTC) #4
On 2009/12/02 21:56:41, anog wrote:
> Looks good to me.

Submitted as r1227
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b