Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1041)

Issue 161056: code review 161056: cgo now assigns 'void' C name to Size<0 (opaque) types ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 7 months ago by eden.li
Modified:
15 years, 7 months ago
Reviewers:
CC:
rsc
Visibility:
Public.

Description

cgo now assigns 'void' C name to Size<0 (opaque) types if dwarf.Common().Type returns nothing. Ideally, the C name would come from the typedef or pointer that references the Size<0 type, but we can't easily generate this without performing a look-ahead to see if any referencing type will become opaque. Fixes issue 334. Fixes issue 281.

Patch Set 1 #

Patch Set 2 : code review 161056: cgo now assigns 'void' C name to Size<0 (opaque) types ... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M src/cmd/cgo/gcc.go View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4
eden.li
Hello rsc, I'd like you to review the following change.
15 years, 7 months ago (2009-11-26 08:36:38 UTC) #1
rsc
LGTM I wonder whether the fixes issue comments need to be on lines of their ...
15 years, 7 months ago (2009-11-29 23:00:32 UTC) #2
rsc
*** Submitted as http://code.google.com/p/go/source/detail?r=8b51beb7d55a *** cgo: use C type void for opaque types if dwarf.Common().Type ...
15 years, 7 months ago (2009-11-30 02:14:44 UTC) #3
rsc
15 years, 7 months ago (2009-12-02 09:53:41 UTC) #4

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b