Issue 161054: [PATCH] Make Path use StringRef instead of std::string where possible

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 161054: [PATCH] Make Path use StringRef instead of std::string where possible (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 3 months ago by Jeffrey Yasskin

Modified:
15 years, 3 months ago

Reviewers:

CC:
llvm-commits_cs.uiuc.edu

Base URL:
https://llvm.org/svn/llvm-project/llvm/trunk/

Visibility:
Public.

Patch Set 1 #

Created: 15 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+69 lines, -67 lines)			Patch
M	include/llvm/System/Path.h	View	10 chunks	+24 lines, -23 lines	0 comments	Download
M	lib/CompilerDriver/CompilationGraph.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/System/Path.cpp	View	4 chunks	+11 lines, -10 lines	0 comments	Download
M	lib/System/Unix/Path.inc	View	9 chunks	+18 lines, -18 lines	0 comments	Download
M	lib/System/Win32/Path.inc	View	9 chunks	+15 lines, -15 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Jeffrey Yasskin

This depends on the patch I just sent to cfe-commits. I wanted to run it ...

15 years, 3 months ago (2009-12-07 23:06:02 UTC) #1

clattner_apple.com

15 years, 3 months ago (2009-12-17 19:47:01 UTC) #2

On Dec 7, 2009, at 3:06 PM, jyasskin@gmail.com wrote:

> Reviewers: ,
> 
> Message:
> This depends on the patch I just sent to cfe-commits. I wanted to run it
> by the list in case there are objections to the interface change (that,
> for example, Path.getSuffix().c_str() no longer works).

This looks like a huge improvement to me, please apply!

-Chris

Expand All Messages | Collapse All Messages