Issue 159060: Mac: Nicer drawing of tab text

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 159060: Mac: Nicer drawing of tab text

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 1 month ago by thakis

Modified:
15 years ago

Reviewers:
dmaclach, dmac, thomasvl, viettrungluu1

Base URL:
http://google-toolbox-for-mac.googlecode.com/svn/trunk/AppKit/

Visibility:
Public.

Description

Mac: Nicer drawing of tab text Before: http://imgur.com/CQYd1.png http://imgur.com/QMPwH.png After: http://imgur.com/Wpnth.png http://imgur.com/Q6zUf.png BUG=28478 TEST=Text in tabs should look just like before with default theme. Text in tabs should look nice with theme "Karim Rashid".

Patch Set 1 #

Total comments: 6

Patch Set 2 : Address comments #

Patch Set 3 : Improve appearance of Grover Cleveland's Wikipedia page #

Created: 15 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -21 lines)			Patch
	M	GTMFadeTruncatingTextFieldCell.m	View	1 2	1 chunk	+41 lines, -21 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

dmaclach

http://codereview.appspot.com/159060/diff/1/2 File GTMFadeTruncatingTextFieldCell.m (right): http://codereview.appspot.com/159060/diff/1/2#newcode41 GTMFadeTruncatingTextFieldCell.m:41: if (size.width <= cellFrame.size.width) { use NSWidth(cellFrame) http://codereview.appspot.com/159060/diff/1/2#newcode65 GTMFadeTruncatingTextFieldCell.m:65: ...

15 years, 1 month ago (2009-11-22 22:59:39 UTC) #3

thakis

15 years, 1 month ago (2009-11-22 23:05:39 UTC) #4

Sent you both a CL to actually land this into GTM.

Expand All Messages | Collapse All Messages