Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(10)

Issue 15740045: python-sql: Add TRUNCATE (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by nicoe
Modified:
11 years ago
Reviewers:
vvanderleun, ced
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : add tests #

Total comments: 3

Patch Set 3 : Add CHANGELOG #

Total comments: 1

Patch Set 4 : Add test on the params #

Total comments: 5

Patch Set 5 : Move truncate to ddl.py #

Patch Set 6 : Add more constraint to create #

Unified diffs Side-by-side diffs Delta from patch set Stats (+327 lines, -1 line) Patch
M CHANGELOG View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M sql/__init__.py View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download
A sql/ddl.py View 1 2 3 4 5 1 chunk +206 lines, -0 lines 0 comments Download
A sql/tests/test_create.py View 1 2 3 4 5 1 chunk +59 lines, -0 lines 0 comments Download
A sql/tests/test_truncate.py View 1 2 3 4 1 chunk +57 lines, -0 lines 0 comments Download

Messages

Total messages: 12
nicoe
12 years, 1 month ago (2013-10-23 14:57:09 UTC) #1
nicoe
12 years, 1 month ago (2013-10-23 15:00:39 UTC) #2
ced
Add a changelog entry https://codereview.appspot.com/15740045/diff/30001/sql/tests/test_truncate.py File sql/tests/test_truncate.py (right): https://codereview.appspot.com/15740045/diff/30001/sql/tests/test_truncate.py#newcode48 sql/tests/test_truncate.py:48: finally: Could also test params ...
12 years, 1 month ago (2013-10-23 16:31:32 UTC) #3
nicoe
https://codereview.appspot.com/15740045/diff/30001/sql/tests/test_truncate.py File sql/tests/test_truncate.py (right): https://codereview.appspot.com/15740045/diff/30001/sql/tests/test_truncate.py#newcode48 sql/tests/test_truncate.py:48: finally: On 2013/10/23 16:31:32, ced wrote: > Could also ...
12 years ago (2013-12-11 09:50:14 UTC) #4
nicoe
12 years ago (2013-12-11 09:50:38 UTC) #5
ced
https://codereview.appspot.com/15740045/diff/30001/sql/tests/test_truncate.py File sql/tests/test_truncate.py (right): https://codereview.appspot.com/15740045/diff/30001/sql/tests/test_truncate.py#newcode48 sql/tests/test_truncate.py:48: finally: On 2013/12/11 09:50:14, nicoe wrote: > On 2013/10/23 ...
12 years ago (2013-12-11 10:06:13 UTC) #6
vvanderleun
LGTM, please push.
11 years, 8 months ago (2014-04-10 10:21:49 UTC) #7
ced
On 2014/04/10 10:21:49, vvanderleun wrote: > LGTM, please push. Not for me.
11 years, 8 months ago (2014-04-10 10:34:46 UTC) #8
ced
https://codereview.appspot.com/15740045/diff/120001/sql/__init__.py File sql/__init__.py (right): https://codereview.appspot.com/15740045/diff/120001/sql/__init__.py#newcode634 sql/__init__.py:634: def __init__(self, table): Truncate can take a list of ...
11 years, 7 months ago (2014-05-03 20:14:24 UTC) #9
ced
TRUNCATE is DDL while currently python-sql is DML only. I don't know if we want ...
11 years, 7 months ago (2014-05-05 10:00:45 UTC) #10
nicoe
https://codereview.appspot.com/15740045/diff/120001/sql/__init__.py File sql/__init__.py (right): https://codereview.appspot.com/15740045/diff/120001/sql/__init__.py#newcode634 sql/__init__.py:634: def __init__(self, table): The list of tables is not ...
11 years, 7 months ago (2014-05-06 16:17:35 UTC) #11
nicoe
11 years, 7 months ago (2014-05-06 16:20:24 UTC) #12
I am not sure we should go on in this direction since the DDL queries seems too
much like one shot queries and they do not seems to require that much pythonic
bindings.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b