Remove hardcoded shortcut and activate Delete key in one2many

[timitos, 2009-11-23 07:07:38]

OK for me.

[timitos, 2009-11-23 18:23:51]

BTW: I noticed this: When i press F3 on a Many2Many with this patch and browse
through the records in the selection dialog i cannot confirm my selection by
pressing Enter. I need to navigate to the OK Button with tab and then i can
press Enter to confirm my selection. Maybe you should improve this in this patch
too.

http://codereview.appspot.com/157125/diff/9/1003
File tryton/gui/window/view_form/view/form_gtk/many2many.py (right):

http://codereview.appspot.com/157125/diff/9/1003#newcode77
tryton/gui/window/view_form/view/form_gtk/many2many.py:77: self._sig_add()
first it was a little bit confusing for me that i can add an entry with F3 but
not create a new one. but on the second run it seems to be reasonable.

[timitos, 2009-11-23 19:41:32]

http://codereview.appspot.com/157125/diff/14/1006
File tryton/gui/window/view_form/view/form_gtk/many2many.py (right):

http://codereview.appspot.com/157125/diff/14/1006#newcode83
tryton/gui/window/view_form/view/form_gtk/many2many.py:83: self._sig_remove()
When i remove a record on a Many2Many the record above the deleted record should
be selected. This would be similar to the behavior of the one2many widget.

http://codereview.appspot.com/157125/diff/14/1008
File tryton/gui/window/win_search.py (right):

http://codereview.appspot.com/157125/diff/14/1008#newcode30
tryton/gui/window/win_search.py:30: 
So why do you use CTRL+Return?
On Many2Many you use F3 to open the selection dialog
On One2Many you use F3 to create a new record
On One2Many i can simply press Return to add the new record.
So why am i not able to press Return so add the selected records to the
Many2Many? Why do i need to use CTRL there?

[ced1, 2009-11-23 20:59:28]

http://codereview.appspot.com/157125/diff/14/1008
File tryton/gui/window/win_search.py (right):

http://codereview.appspot.com/157125/diff/14/1008#newcode30
tryton/gui/window/win_search.py:30: 
On 2009/11/23 19:41:32, timitos wrote:
> So why am i not able to press Return so add the selected records to the
> Many2Many? Why do i need to use CTRL there?
Because you can select many records with Many2Many.

[timitos, 2009-11-23 21:17:29]

http://codereview.appspot.com/157125/diff/14/1008
File tryton/gui/window/win_search.py (right):

http://codereview.appspot.com/157125/diff/14/1008#newcode30
tryton/gui/window/win_search.py:30: 
On 2009/11/23 20:59:28, ced wrote:
> On 2009/11/23 19:41:32, timitos wrote:
> > So why am i not able to press Return so add the selected records to the
> > Many2Many? Why do i need to use CTRL there?
> Because you can select many records with Many2Many.
> 
> 
But i do not see this as an argument for using CTRL. I can select many records
anyway. It happens before pressing Return. And for selection many records Return
is not necessary. You will do this with SHIFT+Arrow-Keys.

http://codereview.appspot.com/157125/diff/18/19
File tryton/gui/window/view_form/view/form_gtk/many2many.py (right):

http://codereview.appspot.com/157125/diff/18/19#newcode76
tryton/gui/window/view_form/view/form_gtk/many2many.py:76: if event.keyval ==
gtk.keysyms.F3:
F3 Key should also work when the cursor is in the search+add-Field(i don't know
how to call this field correctly) of the Many2Many Widget.

[ced1, 2009-11-23 21:20:17]

http://codereview.appspot.com/157125/diff/14/1008
File tryton/gui/window/win_search.py (right):

http://codereview.appspot.com/157125/diff/14/1008#newcode30
tryton/gui/window/win_search.py:30: 
On 2009/11/23 21:17:29, timitos wrote:
> On 2009/11/23 20:59:28, ced wrote:
> > On 2009/11/23 19:41:32, timitos wrote:
> > > So why am i not able to press Return so add the selected records to the
> > > Many2Many? Why do i need to use CTRL there?
> > Because you can select many records with Many2Many.
> > 
> > 
> But i do not see this as an argument for using CTRL. I can select many records
> anyway. It happens before pressing Return. And for selection many records
Return
> is not necessary. You will do this with SHIFT+Arrow-Keys.
> 
Pressing return will select only one.

[timitos, 2009-11-24 08:00:46]

http://codereview.appspot.com/157125/diff/14/1008
File tryton/gui/window/win_search.py (right):

http://codereview.appspot.com/157125/diff/14/1008#newcode30
tryton/gui/window/win_search.py:30: 
On 2009/11/23 21:20:17, ced wrote:
> > 
> Pressing return will select only one.
> 
OK

http://codereview.appspot.com/157125/diff/1018/1019
File tryton/gui/window/view_form/view/form_gtk/many2many.py (right):

http://codereview.appspot.com/157125/diff/1018/1019#newcode83
tryton/gui/window/view_form/view/form_gtk/many2many.py:83: and
self.screen.widget.is_focus():
Deleting is not working with this line on Many2Many. If I comment out this line
everything works fine.

For One2Many this is working.

[yangoon1, 2009-11-25 14:05:13]

Testing:

m2o: F2 = Search/Edit
        Enter = Takes selected record
     F3 = New
        Enter = Takes selected record
     Backspace = Removes selected record
     Del = Nothing

o2m: F2 = Edit
        Enter = Takes selected record
     F3 = New
        Enter = Takes selected record
     Del = Removes selected record(s)

m2m: F2 = Nothing
     F3 = Search
        Enter = Nothing
        4x Tab, Enter = Takes all selected records
        Ctrl + Enter = Takes all selected records
     Del = Removes selected record(s)

Search window (i.e. after partial input in a m2o and matching records > 1):
like m2m: 
     Enter = Nothing
     4x Tab, Enter = Takes selected record
     Ctrl + Enter = Nothing


So for me we have still some inconsistencies:
1)
in m2m {4x Tab, Enter} does the same as {Ctrl + Enter}
  -> Since {Enter} does nothing, {Ctrl + Enter} can be replaced by {Enter}.
2) 
If there is no current record in m2o, there is automatically searched for
existing records (very good).
Why not mimic this behaviour in o2m: if there is no current record (empty
field), open automatically for New instead.
3) 
F2 on m2m does nothing, but should show/edit record. 
4)
As in 2) same for m2m: mimic F3 (New), if there is no current record selected
(empty field).
5)
As in 1) in the Search window {4x Tab, Enter} should not be needed and should be
replaced by {Enter}.

[yangoon1, 2009-11-25 14:08:17]

On 2009/11/25 14:05:13, yangoon wrote:
> Testing:
> 
> m2o: F2 = Search/Edit
>         Enter = Takes selected record
>      F3 = New
>         Enter = Takes selected record
>      Backspace = Removes selected record
>      Del = Nothing

I forgot:
6) Instead of (or additionally to) {Backspace} use {Del} to remove record in
m20.

[ced1, 2009-11-25 14:52:22]

On 2009/11/25 14:05:13, yangoon wrote:
> So for me we have still some inconsistencies:
> 1)
> in m2m {4x Tab, Enter} does the same as {Ctrl + Enter}
>   -> Since {Enter} does nothing, {Ctrl + Enter} can be replaced by {Enter}.

Already explain.

> 2) 
> If there is no current record in m2o, there is automatically searched for
> existing records (very good).
> Why not mimic this behaviour in o2m: if there is no current record (empty
> field), open automatically for New instead.

The behavior of many2one is only when the field is required. And as there is no
requirement on xxx2many fields. This behavior can not be implemented.

> 3) 
> F2 on m2m does nothing, but should show/edit record.

Added.
 
> 4)
> As in 2) same for m2m: mimic F3 (New), if there is no current record selected
> (empty field).

Don't agree. Creating recored from many2many must be a special case and not a
generality. So it is done in the search windows after searching.

> 5)
> As in 1) in the Search window {4x Tab, Enter} should not be needed and should
be
> replaced by {Enter}.

Already explain.

[ced1, 2009-11-25 14:54:33]

On 2009/11/25 14:08:17, yangoon wrote:
> 6) Instead of (or additionally to) {Backspace} use {Del} to remove record in
> m20.

It seems that Backspace is not catchable on widgets.

[timitos, 2009-11-25 19:41:14]

works for me.