code review 157120: Syntax highlighting files for gedit.

Syntax highlighting files for gedit.
includes a color scheme that highlights operators and builtin functions

[KiroiHi, 2009-11-21 01:16:24]

Hello agl1,

I'd like you to review the following change.

[agl, 2009-11-21 01:19:20]

The Kate file appears to be full of conflict markers, although it might just be
that I don't know the syntax.

[KiroiHi, 2009-11-21 05:16:44]

On 2009/11/21 01:19:20, agl wrote:
> The Kate file appears to be full of conflict markers, although it might just
be
> that I don't know the syntax.

Well, I'm not an expert in XML, so it's possible. But it works fine on my
computer. Where do you find conflicts?

[agl, 2009-11-21 18:54:55]

I see that you uploaded a new patch set that removed the conflict markers.

However, you appear to be completely replacing the existing kate syntax file.
That seems a little odd. You should probably consider what was already there and
improve on it. Also, I don't know the Kate syntax so you should probably ask the
existing author to review it.

The gedit stuff is good. If you split that into it's own CL then LGTM, thanks.
(You appear to need to do the legal stuff:
http://golang.org/doc/contribute.html#copyright)

Cheers

[KiroiHi, 2009-11-21 19:26:57]

I've changed the CL to contain only gedit files and added the legal stuff (with
xml style comments).

I'll check deeper the kate xml and generate a new CL for it when it's ready.

Thanks

[agl, 2009-11-21 19:39:44]

LGTM.

The legal stuff that you need to do is the CONTRIBUTORS stuff at the bottom of
http://golang.org/doc/contribute.html#copyright (it should only take a minute).
If you send a CL to rsc for that, he'll get to it on Monday.

Cheers

[KiroiHi, 2009-11-21 20:05:41]

Hello rsc (cc: agl),

I'd like you to review the following change.

[rsc, 2009-11-23 22:21:00]

A few comments.
Looks like maybe a few things from other languages
crept in.

http://codereview.appspot.com/157120/diff/1034/1035
File misc/gedit/README (right):

http://codereview.appspot.com/157120/diff/1034/1035#newcode2
misc/gedit/README:2: By Gilberto Nájera Gutiérrez
We've been avoiding putting people's names
anywhere but the AUTHORS and CONTRIBUTORS files,
so that as files get modified we don't have to keep
these lists up to date.  Please delete this line and the
next one.  Your name and email address will still appear
in the files I just mentioned as well as in the Mercurial
history as having created these files.

Thanks.

http://codereview.appspot.com/157120/diff/1034/1036
File misc/gedit/go.lang (right):

http://codereview.appspot.com/157120/diff/1034/1036#newcode7
misc/gedit/go.lang:7: <!--
This is a second copyright+license block.  Please delete it
in favor of the one above.

http://codereview.appspot.com/157120/diff/1034/1036#newcode81
misc/gedit/go.lang:81: <context ref="def:escape"/>
What does def:escape mean?  
Double quoted strings in Go have a different set of
escape codes than strings in other languages, and
I don't see the definition here.

http://codereview.appspot.com/157120/diff/1034/1036#newcode82
misc/gedit/go.lang:82: <context ref="def:line-continue"/>
What does line-continue mean?

http://codereview.appspot.com/157120/diff/1034/1036#newcode86
misc/gedit/go.lang:86: <context id="single-quoted-string" style-ref="string"
end-at-line-end="true">
This looks like it handles newlines in single
quoted strings, but Go does not.

http://codereview.appspot.com/157120/diff/1034/1036#newcode99
misc/gedit/go.lang:99: <context ref="def:escape"/>
What does def:escape mean?  Backtick quoted strings
have no escape codes.

http://codereview.appspot.com/157120/diff/1034/1036#newcode188
misc/gedit/go.lang:188: <context id="special-tokens" style-ref="special-token">
Not sure why these are here.  They are not part of Go:
there is no preprocessor.

http://codereview.appspot.com/157120/diff/1034/1036#newcode231
misc/gedit/go.lang:231: <context id="binary" style-ref="binary">
This is not part of Go either.

http://codereview.appspot.com/157120/diff/1034/1036#newcode257
misc/gedit/go.lang:257: <context ref="def:shebang"/>
Not sure what this refers to, but it is not part of Go.

[rsc, 2010-01-15 21:51:42]

Timed out.  Moving to golang-dev+timeout.