Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(36)

Issue 157120: code review 157120: Syntax highlighting files for gedit.

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 6 months ago by KiroiHi
Modified:
2 years, 7 months ago
Reviewers:
agl
CC:
golang-dev+timeout_googlegroups.com
Visibility:
Public.

Description

Syntax highlighting files for gedit. includes a color scheme that highlights operators and builtin functions

Patch Set 1 #

Patch Set 2 : code review 157120: Syntax highlighting files for kate and gedit. #

Patch Set 3 : code review 157120: Syntax highlighting files for kate and gedit. #

Patch Set 4 : code review 157120: Syntax highlighting files for kate and gedit. #

Patch Set 5 : code review 157120: Syntax highlighting files for gedit. #

Patch Set 6 : code review 157120: Syntax highlighting files for gedit. #

Total comments: 9

Patch Set 7 : code review 157120: Syntax highlighting files for gedit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+325 lines, -0 lines) Patch
A misc/gedit/README View 1 2 3 4 5 6 1 chunk +6 lines, -0 lines 0 comments Download
A misc/gedit/go.lang View 1 2 3 4 5 6 1 chunk +244 lines, -0 lines 0 comments Download
A misc/gedit/mistyle.xml View 1 2 3 4 5 6 1 chunk +75 lines, -0 lines 0 comments Download

Messages

Total messages: 9
KiroiHi
Hello agl1, I'd like you to review the following change.
16 years, 6 months ago (2009-11-21 01:16:24 UTC) #1
agl
The Kate file appears to be full of conflict markers, although it might just be ...
16 years, 6 months ago (2009-11-21 01:19:20 UTC) #2
KiroiHi
On 2009/11/21 01:19:20, agl wrote: > The Kate file appears to be full of conflict ...
16 years, 6 months ago (2009-11-21 05:16:44 UTC) #3
agl
I see that you uploaded a new patch set that removed the conflict markers. However, ...
16 years, 6 months ago (2009-11-21 18:54:55 UTC) #4
KiroiHi
I've changed the CL to contain only gedit files and added the legal stuff (with ...
16 years, 6 months ago (2009-11-21 19:26:57 UTC) #5
agl
LGTM. The legal stuff that you need to do is the CONTRIBUTORS stuff at the ...
16 years, 6 months ago (2009-11-21 19:39:44 UTC) #6
KiroiHi
Hello rsc (cc: agl), I'd like you to review the following change.
16 years, 6 months ago (2009-11-21 20:05:41 UTC) #7
rsc
A few comments. Looks like maybe a few things from other languages crept in. http://codereview.appspot.com/157120/diff/1034/1035 ...
16 years, 6 months ago (2009-11-23 22:21:00 UTC) #8
rsc
16 years, 4 months ago (2010-01-15 21:51:42 UTC) #9
Timed out.  Moving to golang-dev+timeout.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b